• Kyle Gehmlich's avatar
    fix: remove duplicate query parameters on HTTPS redirect (#6460) · 545ba4ec
    Kyle Gehmlich authored
    HTTPS redirection rebuilds the full URL using req.originalUrl, which
    includes query parameters (see
    https://expressjs.com/en/api.html#req.originalUrl). Prior to this patch,
    appending the stringified query params to req.originalUrl resulted in
    duplicate parameters, e.g.
    wiki.js/callback?session=123&code=abc?session=123&code=abc
    which caused errors when being redirected from an insecure (http://)
    callback URL to a secure version when using OIDC (e.g. with keycloak).
    
    This issue is probably rare, but in cases where HTTPS redirection is
    enabled and a user tries to hit an insecure URL with query parameters,
    it could cause problems.
    545ba4ec
ssl.js 1.05 KB