fix: page rules role check (#1447)

* Check rule.roles against permissions * Added Role Check to EXACT matching * Code Review Fixes

fix: page rules role check (#1447)
7d23344c · BobbyB · GitHub · a694d262 · 7d23344c
Unverified Commit 7d23344c authored Feb 07, 2020 by BobbyB Committed by GitHub Feb 07, 2020
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

auth.js server/core/auth.js +2 -0

No files found.
--- a/server/core/auth.js
+++ b/server/core/auth.js
@@ -173,6 +173,7 @@ module.exports = {
      user.groups.forEach(grp => {
        const grpId = _.isObject(grp) ? _.get(grp, 'id', 0) : grp
        _.get(WIKI.auth.groups, `${grpId}.pageRules`, []).forEach(rule => {
+          if(_.intersection(rule.roles, permissions).length > 0) {
            switch (rule.match) {
              case 'START':
                if (_.startsWith(`/${page.path}`, `/${rule.path}`)) {
@@ -207,6 +208,7 @@ module.exports = {
                }
                break
            }
+          }
        })
      })