fix: issue with Custom Header IDs (#4527)

Fix the issue described in discussion #3502 regarding header links and TOC failing to properly generate when header ID is custom defined.

fix: issue with Custom Header IDs (#4527)
db73b650 · broxen · GitHub · 8aa02318 · db73b650
Unverified Commit db73b650 authored Oct 01, 2021 by broxen Committed by GitHub Oct 01, 2021
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

renderer.js server/modules/rendering/html-core/renderer.js +3 -2

No files found.
--- a/server/modules/rendering/html-core/renderer.js
+++ b/server/modules/rendering/html-core/renderer.js
@@ -201,10 +201,11 @@ module.exports = {

    let headers = []
    $('h1,h2,h3,h4,h5,h6').each((i, elm) => {
+      let headerSlug = uslug($(elm).text())
+      // -> If custom ID is defined, try to use that instead
      if ($(elm).attr('id')) {
-        return
+        headerSlug = $(elm).attr('id')
      }
-      let headerSlug = uslug($(elm).text())

      // -> Cannot start with a number (CSS selector limitation)
      if (headerSlug.match(/^\d/)) {