Skip to content

C
c3-closed
Commit 4fcad88e authored by Masayuki Tanaka's avatar Masayuki Tanaka
Browse files
Options

Fix unexpected rest of body class - #659

parent 48f2d9bf
Show whitespace changes
Inline Side-by-side
Showing with 6 additions and 2 deletions
c3.js
View file @ 4fcad88e
...@@ -3091,7 +3091,8 @@ ...@@ -3091,7 +3091,8 @@
.style("fill-opacity", opacityForText)); .style("fill-opacity", opacityForText));
}; };
c3_chart_internal_fn.getTextRect = function (text, cls) { c3_chart_internal_fn.getTextRect = function (text, cls) {
var svg = this.d3.select('body').attr('class', 'c3').append("svg").style('visibility', 'hidden'), rect; var body = this.d3.select('body').classed('c3', true),
svg = body.append("svg").style('visibility', 'hidden'), rect;
svg.selectAll('.dummy') svg.selectAll('.dummy')
.data([text]) .data([text])
.enter().append('text') .enter().append('text')
...@@ -3099,6 +3100,7 @@ ...@@ -3099,6 +3100,7 @@
.text(text) .text(text)
.each(function () { rect = this.getBoundingClientRect(); }); .each(function () { rect = this.getBoundingClientRect(); });
svg.remove(); svg.remove();
body.classed('c3', false);
return rect; return rect;
}; };
c3_chart_internal_fn.generateXYForText = function (areaIndices, barIndices, lineIndices, forX) { c3_chart_internal_fn.generateXYForText = function (areaIndices, barIndices, lineIndices, forX) {
......
c3.min.js
View file @ 4fcad88e
This source diff could not be displayed because it is too large. You can view the blob instead.
src/text.js
View file @ 4fcad88e
...@@ -48,7 +48,8 @@ c3_chart_internal_fn.addTransitionForText = function (transitions, xForText, yFo ...@@ -48,7 +48,8 @@ c3_chart_internal_fn.addTransitionForText = function (transitions, xForText, yFo
.style("fill-opacity", opacityForText)); .style("fill-opacity", opacityForText));
}; };
c3_chart_internal_fn.getTextRect = function (text, cls) { c3_chart_internal_fn.getTextRect = function (text, cls) {
var svg = this.d3.select('body').attr('class', 'c3').append("svg").style('visibility', 'hidden'), rect; var body = this.d3.select('body').classed('c3', true),
svg = body.append("svg").style('visibility', 'hidden'), rect;
svg.selectAll('.dummy') svg.selectAll('.dummy')
.data([text]) .data([text])
.enter().append('text') .enter().append('text')
...@@ -56,6 +57,7 @@ c3_chart_internal_fn.getTextRect = function (text, cls) { ...@@ -56,6 +57,7 @@ c3_chart_internal_fn.getTextRect = function (text, cls) {
.text(text) .text(text)
.each(function () { rect = this.getBoundingClientRect(); }); .each(function () { rect = this.getBoundingClientRect(); });
svg.remove(); svg.remove();
body.classed('c3', false);
return rect; return rect;
}; };
c3_chart_internal_fn.generateXYForText = function (areaIndices, barIndices, lineIndices, forX) { c3_chart_internal_fn.generateXYForText = function (areaIndices, barIndices, lineIndices, forX) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment