Fix legend item width when data.names called - #775

b0e78535 · Masayuki Tanaka · 57dbe886 · b0e78535 · b0e78535 · b0e78535
Commit b0e78535 authored Nov 30, 2014 by Masayuki Tanaka
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

c3.js c3.js +4 -0

c3.min.js c3.min.js +0 -0

api.data.js src/api.data.js +1 -0

legend.js src/legend.js +3 -0

No files found.
--- a/c3.js
+++ b/c3.js
@@ -3766,6 +3766,9 @@
            .style('visibility', 'hidden');
    };
    var legendItemTextBox = {};
+    c3_chart_internal_fn.clearLegendItemTextBoxCache = function () {
+        legendItemTextBox = {};
+    };
    c3_chart_internal_fn.updateLegend = function (targetIds, options, transitions) {
        var $$ = this, config = $$.config;
        var xForLegend, xForLegendText, xForLegendRect, yForLegend, yForLegendText, yForLegendRect;
@@ -6273,6 +6276,7 @@
        return values;
    };
    c3_chart_fn.data.names = function (names) {
+        this.internal.clearLegendItemTextBoxCache();
        return this.internal.updateDataAttributes('names', names);
    };
    c3_chart_fn.data.colors = function (colors) {

--- a/c3.min.js
+++ b/c3.min.js
--- a/src/api.data.js
+++ b/src/api.data.js
@@ -16,6 +16,7 @@ c3_chart_fn.data.values = function (targetId) {
    return values;
 };
 c3_chart_fn.data.names = function (names) {
+    this.internal.clearLegendItemTextBoxCache();
    return this.internal.updateDataAttributes('names', names);
 };
 c3_chart_fn.data.colors = function (colors) {

--- a/src/legend.js
+++ b/src/legend.js
@@ -100,6 +100,9 @@ c3_chart_internal_fn.hideLegend = function (targetIds) {
        .style('visibility', 'hidden');
 };
 var legendItemTextBox = {};
+c3_chart_internal_fn.clearLegendItemTextBoxCache = function () {
+    legendItemTextBox = {};
+};
 c3_chart_internal_fn.updateLegend = function (targetIds, options, transitions) {
    var $$ = this, config = $$.config;
    var xForLegend, xForLegendText, xForLegendRect, yForLegend, yForLegendText, yForLegendRect;