Avoid updating arc targets when it's not needed - #172

f29b9714 · Masayuki Tanaka · b790f46a · f29b9714 · f29b9714 · f29b9714
Commit f29b9714 authored Jan 11, 2015 by Masayuki Tanaka
Show whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

c3.js c3.js +5 -1

c3.min.js c3.min.js +0 -0

api.transform.js src/api.transform.js +1 -0

core.js src/core.js +4 -1

No files found.
--- a/c3.js
+++ b/c3.js
@@ -413,7 +413,10 @@
        $$.updateTargetsForLine(targets);

        //-- Arc --//
-        if ($$.updateTargetsForArc) { $$.updateTargetsForArc(targets); }
+        if ($$.hasArcType() && $$.updateTargetsForArc) { $$.updateTargetsForArc(targets); }
+
+        /*-- Sub --*/
+
        if ($$.updateTargetsForSubchart) { $$.updateTargetsForSubchart(targets); }

        /*-- Show --*/
@@ -6238,6 +6241,7 @@
        options.withTransitionForTransform = false;
        $$.transiting = false;
        $$.setTargetType(targetIds, type);
+        $$.updateTargets($$.data.targets); // this is needed when transforming to arc
        $$.updateAndRedraw(options);
    };


--- a/c3.min.js
+++ b/c3.min.js
--- a/src/api.transform.js
+++ b/src/api.transform.js
@@ -11,5 +11,6 @@ c3_chart_internal_fn.transformTo = function (targetIds, type, optionsForRedraw) 
    options.withTransitionForTransform = false;
    $$.transiting = false;
    $$.setTargetType(targetIds, type);
+    $$.updateTargets($$.data.targets); // this is needed when transforming to arc
    $$.updateAndRedraw(options);
 };
--- a/src/core.js
+++ b/src/core.js
@@ -408,7 +408,10 @@ c3_chart_internal_fn.updateTargets = function (targets) {
    $$.updateTargetsForLine(targets);

    //-- Arc --//
-    if ($$.updateTargetsForArc) { $$.updateTargetsForArc(targets); }
+    if ($$.hasArcType() && $$.updateTargetsForArc) { $$.updateTargetsForArc(targets); }
+
+    /*-- Sub --*/
+
    if ($$.updateTargetsForSubchart) { $$.updateTargetsForSubchart(targets); }

    /*-- Show --*/