Commit 199c32ea authored by Ulrich Sibiller's avatar Ulrich Sibiller Committed by Mike Gabriel

Screen.c: some more (cosmetic) changes

parent 42fb6833
...@@ -177,7 +177,7 @@ void nxagentPrintAgentGeometry(char *hdrMessage, char *prefix); ...@@ -177,7 +177,7 @@ void nxagentPrintAgentGeometry(char *hdrMessage, char *prefix);
*/ */
int nxagentShadowResize = 0; int nxagentShadowResize = 0;
WindowPtr nxagentShadowWindowPtr = NULL; WindowPtr nxagentShadowWindowPtr = NULL;
static XID accessPixmapID; static XID accessPixmapID;
...@@ -971,7 +971,6 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -971,7 +971,6 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#endif #endif
nxagentChangeOption(Fullscreen, False); nxagentChangeOption(Fullscreen, False);
nxagentChangeOption(AllScreens, False); nxagentChangeOption(AllScreens, False);
nxagentFullscreenWindow = 0; nxagentFullscreenWindow = 0;
...@@ -1162,7 +1161,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1162,7 +1161,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#if defined(DEBUG) || defined(DEBUG_COLORMAP) #if defined(DEBUG) || defined(DEBUG_COLORMAP)
fprintf(stderr, "Debug: Setting up visuals. Original array has size " fprintf(stderr, "Debug: Setting up visuals. Original array has size "
"[%d].\n", nxagentNumVisuals); "[%d].\n", nxagentNumVisuals);
#endif #endif
int numVisuals = 0; int numVisuals = 0;
...@@ -1196,7 +1195,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1196,7 +1195,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#if defined(DEBUG) || defined(DEBUG_COLORMAP) #if defined(DEBUG) || defined(DEBUG_COLORMAP)
fprintf(stderr, "Debug: Set default visual index [%d].\n" , fprintf(stderr, "Debug: Set default visual index [%d].\n" ,
defaultVisualIndex); defaultVisualIndex);
#endif #endif
} }
else else
...@@ -1216,7 +1215,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1216,7 +1215,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
visuals[numVisuals].offsetBlue == visuals[j].offsetBlue) visuals[numVisuals].offsetBlue == visuals[j].offsetBlue)
break; break;
} }
if (j < numVisuals) if (j < numVisuals)
continue; continue;
} }
...@@ -1225,7 +1224,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1225,7 +1224,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#if defined(DEBUG) || defined(DEBUG_COLORMAP) #if defined(DEBUG) || defined(DEBUG_COLORMAP)
fprintf(stderr, "Debug: Added visual [%lu].\n" , fprintf(stderr, "Debug: Added visual [%lu].\n" ,
(long unsigned int)visuals[numVisuals].vid); (long unsigned int)visuals[numVisuals].vid);
#endif #endif
for (int j = 0; j < numDepths; j++) for (int j = 0; j < numDepths; j++)
...@@ -1265,7 +1264,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1265,7 +1264,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#if defined(DEBUG) || defined(DEBUG_COLORMAP) #if defined(DEBUG) || defined(DEBUG_COLORMAP)
fprintf(stderr, "Debug: Registered visual [%lu] for depth [%d (%d)].\n" , fprintf(stderr, "Debug: Registered visual [%lu] for depth [%d (%d)].\n" ,
(long unsigned int)visuals[numVisuals].vid, depthIndex, (long unsigned int)visuals[numVisuals].vid, depthIndex,
depths[depthIndex].depth); depths[depthIndex].depth);
#endif #endif
numVisuals++; numVisuals++;
...@@ -1276,7 +1275,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1276,7 +1275,7 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
defaultVisualIndex, (long unsigned int)visuals[defaultVisualIndex].vid); defaultVisualIndex, (long unsigned int)visuals[defaultVisualIndex].vid);
fprintf(stderr, "Debug: Setting root depth [%d].\n", fprintf(stderr, "Debug: Setting root depth [%d].\n",
visuals[defaultVisualIndex].nplanes); visuals[defaultVisualIndex].nplanes);
#endif #endif
VisualID defaultVisual = visuals[defaultVisualIndex].vid; VisualID defaultVisual = visuals[defaultVisualIndex].vid;
...@@ -1343,9 +1342,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1343,9 +1342,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#endif #endif
/* /*
* Complete the initialization of the GLX * Complete the initialization of the GLX extension. This will add
* extension. This will add the GLX visuals * the GLX visuals and will modify numVisuals and numDepths.
* and will modify numVisuals and numDepths.
*/ */
#if defined(DEBUG) || defined(DEBUG_COLORMAP) #if defined(DEBUG) || defined(DEBUG_COLORMAP)
...@@ -1364,8 +1362,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1364,8 +1362,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
#endif #endif
/* /*
* Replace the visuals and depths initialized * Replace the visuals and depths initialized by fbScreenInit with
* by fbScreenInit with our own. * our own.
*/ */
freeDepths(pScreen->allowedDepths, pScreen->numDepths); freeDepths(pScreen->allowedDepths, pScreen->numDepths);
...@@ -1379,9 +1377,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[]) ...@@ -1379,9 +1377,8 @@ Bool nxagentOpenScreen(ScreenPtr pScreen, int argc, char *argv[])
pScreen -> rootVisual = defaultVisual; pScreen -> rootVisual = defaultVisual;
/* /*
* Set up the internal structures used for * Set up the internal structures used for tracking the proxy
* tracking the proxy resources associated * resources associated to the unpack and split operations.
* to the unpack and split operations.
*/ */
nxagentInitSplitResources(); nxagentInitSplitResources();
...@@ -1419,9 +1416,9 @@ N/A ...@@ -1419,9 +1416,9 @@ N/A
if (nxagentOption(Fullscreen)) if (nxagentOption(Fullscreen))
{ {
/* /*
* We need to disable the host's screensaver or * We need to disable the host's screensaver or it will
* it will otherwise grab the screen even if it * otherwise grab the screen even if it is under agent's
* is under agent's control. * control.
*/ */
XSetScreenSaver(nxagentDisplay, 0, 0, DefaultExposures, DefaultBlanking); XSetScreenSaver(nxagentDisplay, 0, 0, DefaultExposures, DefaultBlanking);
...@@ -1444,7 +1441,7 @@ N/A ...@@ -1444,7 +1441,7 @@ N/A
* *
* if (!miScreenInit(pScreen, NULL, nxagentOption(RootWidth), * if (!miScreenInit(pScreen, NULL, nxagentOption(RootWidth),
* nxagentOption(RootHeight), 1, 1, nxagentOption(RootWidth), * nxagentOption(RootHeight), 1, 1, nxagentOption(RootWidth),
* visuals[nxagentDefaultVisualIndex].nplanes, / * Root depth. * / * visuals[nxagentDefaultVisualIndex].nplanes, / * Root depth. * /
* numDepths, depths, * numDepths, depths,
* visuals[nxagentDefaultVisualIndex].vid,* Root visual. * / * visuals[nxagentDefaultVisualIndex].vid,* Root visual. * /
* numVisuals, visuals)) * numVisuals, visuals))
...@@ -1494,7 +1491,7 @@ N/A ...@@ -1494,7 +1491,7 @@ N/A
/* /*
* Window Procedures. * Window Procedures.
* *
* Note that the following functions are not * Note that the following functions are not
* replaced with nxagent counterparts: * replaced with nxagent counterparts:
* *
...@@ -1528,9 +1525,8 @@ N/A ...@@ -1528,9 +1525,8 @@ N/A
pScreen->DestroyPixmap = nxagentDestroyPixmap; pScreen->DestroyPixmap = nxagentDestroyPixmap;
/* /*
* This is originally miModifyPixmapHeader() * This is originally miModifyPixmapHeader() from miscrinit.c. It
* from miscrinit.c. It is used to recycle * is used to recycle the scratch pixmap for this screen.
* the scratch pixmap for this screen.
*/ */
pScreen->ModifyPixmapHeader = nxagentModifyPixmapHeader; pScreen->ModifyPixmapHeader = nxagentModifyPixmapHeader;
...@@ -1599,18 +1595,16 @@ N/A ...@@ -1599,18 +1595,16 @@ N/A
#ifdef RENDER #ifdef RENDER
/* /*
* Initialize picture support. This have to be * Initialize picture support. This have to be placed here because
* placed here because miDCInitialize calls * miDCInitialize calls DamageSetup, that should wrap the picture
* DamageSetup, that should wrap the picture * screen functions. So PictureInit has to be called before.
* screen functions. So PictureInit has to be
* called before.
*/ */
if (nxagentRenderEnable && !nxagentReconnectTrap) if (nxagentRenderEnable && !nxagentReconnectTrap)
{ {
if (!nxagentPictureInit(pScreen, 0, 0)) if (!nxagentPictureInit(pScreen, 0, 0))
{ {
nxagentRenderEnable = False; nxagentRenderEnable = False;
return FALSE; return FALSE;
} }
...@@ -1650,8 +1644,7 @@ N/A ...@@ -1650,8 +1644,7 @@ N/A
nxagentOption(Height)) / 32) nxagentOption(Height)) / 32)
/* /*
* Complete the initialization of the RANDR * Complete the initialization of the RANDR extension.
* extension.
*/ */
nxagentInitRandRExtension(pScreen); nxagentInitRandRExtension(pScreen);
...@@ -1686,7 +1679,6 @@ N/A ...@@ -1686,7 +1679,6 @@ N/A
* it will otherwise grab the screen even if it * it will otherwise grab the screen even if it
* is under agent's control. * is under agent's control.
*/ */
XSetScreenSaver(nxagentDisplay, 0, 0, DefaultExposures, DefaultBlanking); XSetScreenSaver(nxagentDisplay, 0, 0, DefaultExposures, DefaultBlanking);
} }
} }
...@@ -1705,10 +1697,9 @@ N/A ...@@ -1705,10 +1697,9 @@ N/A
else else
{ {
/* /*
* Create any top-level window as a child of the * Create any top-level window as a child of the real root of
* real root of the remote display. See also the * the remote display. See also the InitRootWindow() procedure
* InitRootWindow() procedure and the function * and the function handling the splash screen.
* handling the splash screen.
*/ */
#ifdef TEST #ifdef TEST
...@@ -1943,10 +1934,9 @@ N/A ...@@ -1943,10 +1934,9 @@ N/A
} }
/* /*
* The purpose of this check is to verify if there * The purpose of this check is to verify if there is a window
* is a window manager running. Unfortunately due * manager running. Unfortunately due to the way we manage the
* to the way we manage the intern atoms call, the * intern atoms call, the atom will always exist.
* atom will always exist.
*/ */
if (nxagentWMIsRunning) if (nxagentWMIsRunning)
...@@ -1988,9 +1978,9 @@ N/A ...@@ -1988,9 +1978,9 @@ N/A
else else
{ {
/* /*
* We should always enable the configuration of the * We should always enable the configuration of the remote X
* remote X server's devices if we are running full- * server's devices if we are running fullscreen and there is no
* screen and there is no WM running. * WM running.
*/ */
if (nxagentOption(Fullscreen)) if (nxagentOption(Fullscreen))
...@@ -2004,9 +1994,8 @@ N/A ...@@ -2004,9 +1994,8 @@ N/A
} }
/* /*
* Inform the user whether the agent's clients will * Inform the user whether the agent's clients will be able to
* be able to change the real X server's keyboard * change the real X server's keyboard and pointer settings.
* and pointer settings.
*/ */
if (nxagentOption(DeviceControl) == False) if (nxagentOption(DeviceControl) == False)
...@@ -2040,9 +2029,8 @@ N/A ...@@ -2040,9 +2029,8 @@ N/A
#endif /* RENDER */ #endif /* RENDER */
/* /*
* Check if the composite extension is * Check if the composite extension is supported on the remote
* supported on the remote display and * display and prepare the agent for its use.
* prepare the agent for its use.
*/ */
nxagentCompositeExtensionInit(); nxagentCompositeExtensionInit();
...@@ -2265,7 +2253,7 @@ Bool nxagentResizeScreen(ScreenPtr pScreen, int width, int height, ...@@ -2265,7 +2253,7 @@ Bool nxagentResizeScreen(ScreenPtr pScreen, int width, int height,
#ifdef TEST #ifdef TEST
nxagentPrintAgentGeometry("Before Resize Screen", "nxagentResizeScreen:"); nxagentPrintAgentGeometry("Before Resize Screen", "nxagentResizeScreen:");
#endif #endif
/* /*
* Change screen properties. * Change screen properties.
*/ */
...@@ -2487,7 +2475,7 @@ void nxagentShadowSetWindowsSize(void) ...@@ -2487,7 +2475,7 @@ void nxagentShadowSetWindowsSize(void)
XResizeWindow(nxagentDisplay, nxagentDefaultWindows[0], XResizeWindow(nxagentDisplay, nxagentDefaultWindows[0],
nxagentOption(Width), nxagentOption(Height)); nxagentOption(Width), nxagentOption(Height));
XMoveResizeWindow(nxagentDisplay, nxagentInputWindows[0], 0, 0, XMoveResizeWindow(nxagentDisplay, nxagentInputWindows[0], 0, 0,
nxagentOption(Width), nxagentOption(Height)); nxagentOption(Width), nxagentOption(Height));
} }
...@@ -3439,7 +3427,7 @@ Bool nxagentReconnectScreen(void *p0) ...@@ -3439,7 +3427,7 @@ Bool nxagentReconnectScreen(void *p0)
return False; return False;
} }
nxagentPixmap(pPixmap) = XCreatePixmap(nxagentDisplay, nxagentPixmap(pPixmap) = XCreatePixmap(nxagentDisplay,
nxagentDefaultWindows[nxagentDefaultScreen->myNum], nxagentDefaultWindows[nxagentDefaultScreen->myNum],
pPixmap -> drawable.width, pPixmap -> drawable.width,
pPixmap -> drawable.height, pPixmap -> drawable.height,
...@@ -3453,10 +3441,10 @@ Bool nxagentReconnectScreen(void *p0) ...@@ -3453,10 +3441,10 @@ Bool nxagentReconnectScreen(void *p0)
CARD16 h = 16; CARD16 h = 16;
(*nxagentDefaultScreen->QueryBestSize)(StippleShape, &w, &h, nxagentDefaultScreen); (*nxagentDefaultScreen->QueryBestSize)(StippleShape, &w, &h, nxagentDefaultScreen);
if (!(nxagentPixmap(nxagentDefaultScreen->PixmapPerDepth[0]) = if (!(nxagentPixmap(nxagentDefaultScreen->PixmapPerDepth[0]) =
XCreatePixmap(nxagentDisplay, XCreatePixmap(nxagentDisplay,
nxagentDefaultDrawables[1], nxagentDefaultDrawables[1],
w, w,
h, h,
1))); 1)));
Mask mask = nxagentGetDefaultEventMask(); Mask mask = nxagentGetDefaultEventMask();
...@@ -3478,7 +3466,7 @@ Bool nxagentReconnectScreen(void *p0) ...@@ -3478,7 +3466,7 @@ Bool nxagentReconnectScreen(void *p0)
nxagentSetTimeoutTimer(0); nxagentSetTimeoutTimer(0);
return True; return True;
} }
/* intersect two rectangles */ /* intersect two rectangles */
...@@ -3945,7 +3933,7 @@ int nxagentAdjustRandRXinerama(ScreenPtr pScreen) ...@@ -3945,7 +3933,7 @@ int nxagentAdjustRandRXinerama(ScreenPtr pScreen)
sprintf(name, "NX%d", i+1); sprintf(name, "NX%d", i+1);
output = RROutputCreate(pScreen, name, strlen(name), NULL); output = RROutputCreate(pScreen, name, strlen(name), NULL);
/* will be done later /* will be done later
RROutputSetConnection(output, RR_Disconnected); RROutputSetConnection(output, RR_Disconnected);
*/ */
#ifdef DEBUG #ifdef DEBUG
fprintf(stderr, "nxagentAdjustRandRXinerama: created new output [%s]\n", name); fprintf(stderr, "nxagentAdjustRandRXinerama: created new output [%s]\n", name);
...@@ -4658,7 +4646,7 @@ void nxagentFbRestoreArea(PixmapPtr pPixmap, WindowPtr pWin, int xSrc, int ySrc, ...@@ -4658,7 +4646,7 @@ void nxagentFbRestoreArea(PixmapPtr pPixmap, WindowPtr pWin, int xSrc, int ySrc,
XImage *image = XGetImage(nxagentDisplay, nxagentPixmap(pPixmap), xSrc, ySrc, XImage *image = XGetImage(nxagentDisplay, nxagentPixmap(pPixmap), xSrc, ySrc,
width, height, AllPlanes, format); width, height, AllPlanes, format);
*/ */
if (image == NULL) if (image == NULL)
{ {
#ifdef WARNING #ifdef WARNING
...@@ -4683,9 +4671,9 @@ FIXME ...@@ -4683,9 +4671,9 @@ FIXME
#ifdef WARNING #ifdef WARNING
fprintf(stderr, "nxagentFbRestoreArea: WARNING! Visual not found. Using default visual.\n"); fprintf(stderr, "nxagentFbRestoreArea: WARNING! Visual not found. Using default visual.\n");
#endif #endif
pVisual = nxagentVisuals[nxagentDefaultVisualIndex].visual; pVisual = nxagentVisuals[nxagentDefaultVisualIndex].visual;
} }
image = XCreateImage(nxagentDisplay, pVisual, image = XCreateImage(nxagentDisplay, pVisual,
depth, format, 0, (char *) data, depth, format, 0, (char *) data,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment