Commit 1a9d96e0 authored by Ulrich Sibiller's avatar Ulrich Sibiller Committed by Mike Gabriel

Render.c: reformat comments

parent 56aaea90
...@@ -446,11 +446,10 @@ void nxagentRenderExtensionInit(void) ...@@ -446,11 +446,10 @@ void nxagentRenderExtensionInit(void)
XRenderQueryVersion(nxagentDisplay, &major_version, &minor_version); XRenderQueryVersion(nxagentDisplay, &major_version, &minor_version);
/* /*
* As the RENDER requests are passed directly to * As the RENDER requests are passed directly to the remote X
* the remote X server this can cause problems if * server this can cause problems if our RENDER version is
* our RENDER version is different from the version * different from the version supported by the remote. For this
* supported by the remote. For this reasons let's * reasons let's advertise to our clients the lowest between the
* advertise to our clients the lowest between the
* two versions. * two versions.
*/ */
...@@ -1070,11 +1069,9 @@ void nxagentChangePicture(PicturePtr pPicture, Mask mask) ...@@ -1070,11 +1069,9 @@ void nxagentChangePicture(PicturePtr pPicture, Mask mask)
if (mask & CPClipMask) if (mask & CPClipMask)
{ {
/* /*
* The nxagent doesn't know the remote id of * The nxagent doesn't know the remote id of the picture's clip
* the picture's clip mask, so the clip_mask * mask, so the clip_mask value is used as a boolean: it is set to
* value is used as a boolean: it is set to 0 * 0 when the clip_mask is None, otherwise it is 1.
* when the clip_mask is None, otherwise it is
* 1.
*/ */
attributes.clip_mask = None; attributes.clip_mask = None;
...@@ -1237,11 +1234,10 @@ void nxagentComposite(CARD8 op, PicturePtr pSrc, PicturePtr pMask, PicturePtr pD ...@@ -1237,11 +1234,10 @@ void nxagentComposite(CARD8 op, PicturePtr pSrc, PicturePtr pMask, PicturePtr pD
} }
/* /*
* Synchronize the content of the shared memory pixmap * Synchronize the content of the shared memory pixmap but pay
* but pay attention at not doing this more than once. * attention at not doing this more than once. We need to wait
* We need to wait until the image data has been recom- * until the image data has been recom- posed at the X server side
* posed at the X server side or the operation will use * or the operation will use the wrong data.
* the wrong data.
*/ */
if (pSrc -> pDrawable != NULL) if (pSrc -> pDrawable != NULL)
...@@ -1292,14 +1288,12 @@ void nxagentComposite(CARD8 op, PicturePtr pSrc, PicturePtr pMask, PicturePtr pD ...@@ -1292,14 +1288,12 @@ void nxagentComposite(CARD8 op, PicturePtr pSrc, PicturePtr pMask, PicturePtr pD
} }
/* /*
* The glyphs flag have to be propagated between * The glyphs flag have to be propagated between drawables, in order
* drawables, in order to avoid to encode the * to avoid to encode the text with lossy algorithms (like
* text with lossy algorithms (like JPEG). Unlu- * JPEG). Unlu- ckily we have verified that if the render com-
* ckily we have verified that if the render com- * posite propagates the flag, the deferring of render trapezoids
* posite propagates the flag, the deferring of * doesn't work well. Moreover, by commenting out this code we have
* render trapezoids doesn't work well. Moreover, * not noticed any visual problems.
* by commenting out this code we have not noticed
* any visual problems.
* *
* if (nxagentDrawableContainGlyphs(pSrc -> pDrawable) == 1) * if (nxagentDrawableContainGlyphs(pSrc -> pDrawable) == 1)
* { * {
...@@ -1369,10 +1363,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst, ...@@ -1369,10 +1363,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst,
glyphBox.y2 = nxagentGlyphsExtents -> y2; glyphBox.y2 = nxagentGlyphsExtents -> y2;
/* /*
* By extending the glyph extents the * By extending the glyph extents the visual aspect looks nicer
* visual aspect looks nicer because * because the synchronized region is not glued to the fonts.
* the synchronized region is not glued
* to the fonts.
*/ */
if (glyphBox.x2 != glyphBox.x1) if (glyphBox.x2 != glyphBox.x1)
...@@ -1389,8 +1381,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst, ...@@ -1389,8 +1381,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst,
} }
/* /*
* If the destination window is hidden, the * If the destination window is hidden, the operation can be
* operation can be prevented. * prevented.
*/ */
if (pDst -> pDrawable -> type == DRAWABLE_WINDOW) if (pDst -> pDrawable -> type == DRAWABLE_WINDOW)
...@@ -1414,9 +1406,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst, ...@@ -1414,9 +1406,8 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst,
} }
/* /*
* Need to synchronize the pixmaps involved in * Need to synchronize the pixmaps involved in the operation before
* the operation before rendering the glyphs * rendering the glyphs on the real X server.
* on the real X server.
*/ */
if (pSrc -> pDrawable != NULL && if (pSrc -> pDrawable != NULL &&
...@@ -1431,11 +1422,9 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst, ...@@ -1431,11 +1422,9 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst,
#endif #endif
/* /*
* If the source drawable is going to be * If the source drawable is going to be repeated over the
* repeated over the destination drawable * destination drawable during the composite operation, we need to
* during the composite operation, we need * synchronize the whole drawable to avoid graphical problems.
* to synchronize the whole drawable to
* avoid graphical problems.
*/ */
if (pSrc -> repeat == 1 || nxagentGlyphsExtents == NullBox) if (pSrc -> repeat == 1 || nxagentGlyphsExtents == NullBox)
...@@ -1537,12 +1526,10 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst, ...@@ -1537,12 +1526,10 @@ void nxagentGlyphs(CARD8 op, PicturePtr pSrc, PicturePtr pDst,
GlyphPtr glyph; GlyphPtr glyph;
/* /*
* We split glyphs lists here and recalculate * We split glyphs lists here and recalculate the offsets of each
* the offsets of each list to make them ab- * list to make them ab- solute and not relatives to the prior list.
* solute and not relatives to the prior list. * This way each time we call XRenderComposi- teText it has to deal
* This way each time we call XRenderComposi- * only with a list of glyphs. This is done to further improve
* teText it has to deal only with a list of
* glyphs. This is done to further improve
* caching. * caching.
*/ */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment