Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nx-libs
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dimbor
nx-libs
Commits
d1fe6a60
Commit
d1fe6a60
authored
Apr 04, 2019
by
Mihai Moldovan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
nxproxy/{m4,configure.ac,src/Makefile.am}: drop pthread overlinking.
Should be fixed by correctly building libXcomp. See: ArcticaProject/nx-libs#756
parent
95f8cf7e
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
16 deletions
+0
-16
configure.ac
nxproxy/configure.ac
+0
-11
ax_pthread.m4
nxproxy/m4/ax_pthread.m4
+0
-2
Makefile.am
nxproxy/src/Makefile.am
+0
-3
No files found.
nxproxy/configure.ac
View file @
d1fe6a60
...
...
@@ -28,17 +28,6 @@ NX_DEFAULT_OPTIONS
NX_TARGET_USE_ELF
dnl This is a workaround for a nasty libtool bug.
dnl We actually compile libXcomp with pthread support, but libtool uses g++ ... -nostdlib ... -pthread
dnl on Linux. -nostdlib causes -pthread to be ignored.
dnl According to GCC upstream, this is not a bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25460
dnl GCC upstream insists that libtool needs to handle -pthread in a special way when using -nostdlib.
dnl A patch has been submitted to the libtool project: http://lists.gnu.org/archive/html/libtool-patches/2013-11/msg00015.html
dnl but never applied to the code base. Boo.
dnl We will work around this bug by using AX_PTHREAD and linking with pthread support in all consumers of
dnl libXcomp for now.
AX_PTHREAD([], AC_MSG_ERROR([no POSIX threads support detected]))
AC_CONFIG_FILES([
Makefile
man/Makefile
...
...
nxproxy/m4/ax_pthread.m4
deleted
120000 → 0
View file @
95f8cf7e
../../m4/ax_pthread.m4
\ No newline at end of file
nxproxy/src/Makefile.am
View file @
d1fe6a60
...
...
@@ -9,12 +9,10 @@ nxproxy_SOURCES = \
$(NULL)
nxproxy_LDADD
=
\
@PTHREAD_LIBS@
\
-L
$(top_srcdir)
/../nxcomp/src/.libs
-lXcomp
\
$(NULL)
nxproxy_LDFLAGS
=
\
$(PTHREAD_LDFLAGS)
\
$(NULL)
if
TARGET_ELF
...
...
@@ -25,7 +23,6 @@ endif TARGET_ELF
nxproxy_CFLAGS
=
\
$(BASE_CFLAGS)
\
$(PTHREAD_CFLAGS)
\
$(NULL)
AM_CPPFLAGS
=
\
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment