Bug 787529: Use |use 5.10.1| everywhere

Bugzilla.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla;
 
+use 5.10.1;
 use strict;
 
 # We want any compile errors to get to the browser, if possible.

Bugzilla/Attachment.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Attachment;
 
+use 5.10.1;
+use strict;
+
 =head1 NAME
 
 Bugzilla::Attachment - Bugzilla attachment class.

Bugzilla/Attachment/PatchReader.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Attachment::PatchReader;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Error;
 use Bugzilla::Attachment;
 use Bugzilla::Util;

Bugzilla/Auth.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Auth;
 
+use 5.10.1;
 use strict;
 use fields qw(
     _info_getter

Bugzilla/Auth/Login.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Auth::Login;
 
+use 5.10.1;
 use strict;
 use fields qw();
 

Bugzilla/Auth/Login/CGI.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Login::CGI;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Login);
 use constant user_can_create_account => 1;
 

Bugzilla/Auth/Login/Cookie.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Login::Cookie;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Login);
 
 use Bugzilla::Constants;

Bugzilla/Auth/Login/Env.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Login::Env;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Login);
 
 use Bugzilla::Constants;

Bugzilla/Auth/Login/Stack.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Login::Stack;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Login);
 use fields qw(
     _stack

Bugzilla/Auth/Persist/Cookie.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Persist::Cookie;
+
+use 5.10.1;
 use strict;
 use fields qw();
 

Bugzilla/Auth/Verify.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Auth::Verify;
 
+use 5.10.1;
 use strict;
 use fields qw();
 

Bugzilla/Auth/Verify/DB.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Verify::DB;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Verify);
 
 use Bugzilla::Constants;

Bugzilla/Auth/Verify/LDAP.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Verify::LDAP;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Verify);
 use fields qw(
     ldap

Bugzilla/Auth/Verify/RADIUS.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Verify::RADIUS;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Verify);
 
 use Bugzilla::Constants;

Bugzilla/Auth/Verify/Stack.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Auth::Verify::Stack;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Auth::Verify);
 use fields qw(
     _stack

Bugzilla/Bug.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Bug;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Attachment;

Bugzilla/BugMail.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::BugMail;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Error;
 use Bugzilla::User;
 use Bugzilla::Constants;

Bugzilla/BugUrl.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Util;

Bugzilla/BugUrl/Bugzilla.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Bugzilla;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 use Bugzilla::Error;

Bugzilla/BugUrl/Bugzilla/Local.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Bugzilla::Local;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl::Bugzilla);
 
 use Bugzilla::Error;

Bugzilla/BugUrl/Debian.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Debian;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/GitHub.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::GitHub;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/Google.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Google;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/JIRA.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::JIRA;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/Launchpad.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Launchpad;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/MantisBT.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::MantisBT;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/SourceForge.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::SourceForge;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/BugUrl/Trac.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::BugUrl::Trac;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::BugUrl);
 
 ###############################

Bugzilla/CGI.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::CGI;
+
+use 5.10.1;
 use strict;
+
 use base qw(CGI);
 
 use Bugzilla::Constants;

Bugzilla/Chart.pm

@@ -5,8 +5,6 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 # This module represents a chart.
 #
 # Note that it is perfectly legal for the 'lines' member variable of this
@@ -15,6 +13,9 @@ use strict;
 # the same points.
 package Bugzilla::Chart;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Series;

Bugzilla/Classification.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Classification;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Constants;
 use Bugzilla::Field;
 use Bugzilla::Util;

Bugzilla/Comment.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Comment;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Attachment;

Bugzilla/Component.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Component;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/Config.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config;
 
+use 5.10.1;
 use strict;
 
 use base qw(Exporter);

Bugzilla/Config/Admin.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Admin;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/Advanced.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Config::Advanced;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/Attachment.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Attachment;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/Auth.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Auth;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/BugChange.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::BugChange;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/BugFields.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::BugFields;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/Common.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Common;
 
+use 5.10.1;
 use strict;
 
 use Email::Address;

Bugzilla/Config/Core.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Core;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/DependencyGraph.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::DependencyGraph;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/General.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Config::General;
+
+use 5.10.1;
 use strict;
+
 use Bugzilla::Config::Common;
 
 our $sortkey = 150;

Bugzilla/Config/GroupSecurity.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::GroupSecurity;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/LDAP.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::LDAP;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/MTA.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::MTA;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/PatchViewer.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::PatchViewer;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/Query.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::Query;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/RADIUS.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::RADIUS;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/ShadowDB.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::ShadowDB;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Config/UserMatch.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Config::UserMatch;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Config::Common;

Bugzilla/Constants.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Constants;
+
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 
 # For bz_locations

Bugzilla/DB.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::DB;
 
+use 5.10.1;
 use strict;
 
 use DBI;

Bugzilla/DB/Mysql.pm

@@ -20,7 +20,10 @@ For interface details see L<Bugzilla::DB> and L<DBI>.
 =cut
 
 package Bugzilla::DB::Mysql;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::DB);
 
 use Bugzilla::Constants;

Bugzilla/DB/Oracle.pm

@@ -20,7 +20,10 @@ For interface details see L<Bugzilla::DB> and L<DBI>.
 =cut
 
 package Bugzilla::DB::Oracle;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::DB);
 
 use DBD::Oracle;
@@ -706,6 +709,10 @@ sub _get_create_trigger_ddl {
 ############################################################################
 
 package Bugzilla::DB::Oracle::st;
+
+use 5.10.1;
+use strict;
+
 use base qw(DBI::st);
  
 sub fetchrow_arrayref {

Bugzilla/DB/Pg.pm

@@ -21,6 +21,7 @@ For interface details see L<Bugzilla::DB> and L<DBI>.
 
 package Bugzilla::DB::Pg;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Error;

Bugzilla/DB/Schema.pm

@@ -15,7 +15,9 @@ package Bugzilla::DB::Schema;
 #
 ###########################################################################
 
+use 5.10.1;
 use strict;
+
 use Bugzilla::Error;
 use Bugzilla::Hook;
 use Bugzilla::Util;

Bugzilla/DB/Schema/Mysql.pm

@@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Mysql;
 #
 ###############################################################################
 
+use 5.10.1;
 use strict;
+
 use Bugzilla::Error;
 
 use base qw(Bugzilla::DB::Schema);

Bugzilla/DB/Schema/Oracle.pm

@@ -13,6 +13,7 @@ package Bugzilla::DB::Schema::Oracle;
 #
 ###############################################################################
 
+use 5.10.1;
 use strict;
 
 use base qw(Bugzilla::DB::Schema);

Bugzilla/DB/Schema/Pg.pm

@@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Pg;
 #
 ###############################################################################
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::DB::Schema);
 use Storable qw(dclone);
 

Bugzilla/DB/Schema/Sqlite.pm

@@ -5,8 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
 package Bugzilla::DB::Schema::Sqlite;
+
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::DB::Schema);
 
 use Bugzilla::Error;

Bugzilla/DB/Sqlite.pm

@@ -5,8 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
 package Bugzilla::DB::Sqlite;
+
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::DB);
 
 use Bugzilla::Constants;

Bugzilla/Error.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::Error;
 
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 
 @Bugzilla::Error::EXPORT = qw(ThrowCodeError ThrowTemplateError ThrowUserError);

Bugzilla/Extension.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Extension;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Field.pm

@@ -57,6 +57,7 @@ in addition to what is documented here.
 
 package Bugzilla::Field;
 
+use 5.10.1;
 use strict;
 
 use base qw(Exporter Bugzilla::Object);

Bugzilla/Field/Choice.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Field::Choice;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 
 use Bugzilla::Config qw(SetParam write_params);

Bugzilla/Field/ChoiceInterface.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Field::ChoiceInterface;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Flag.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Flag;
 
+use 5.10.1;
+use strict;
+
 =head1 NAME
 
 Bugzilla::Flag - A module to deal with Bugzilla flag values.

Bugzilla/FlagType.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::FlagType;
 
+use 5.10.1;
+use strict;
+
 =head1 NAME
 
 Bugzilla::FlagType - A module to deal with Bugzilla flag types.

Bugzilla/Group.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Group;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/Hook.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Hook;
+
+use 5.10.1;
 use strict;
 
 sub process {

Bugzilla/Install.pm

@@ -15,6 +15,7 @@ package Bugzilla::Install;
 # make those assumptions, then it should go into one of the
 # packages under the Bugzilla::Install namespace.
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Component;
@@ -25,7 +26,7 @@ use Bugzilla::Group;
 use Bugzilla::Product;
 use Bugzilla::User;
 use Bugzilla::User::Setting;
-use Bugzilla::Util qw(get_text say);
+use Bugzilla::Util qw(get_text);
 use Bugzilla::Version;
 
 use constant STATUS_WORKFLOW => (

Bugzilla/Install/CPAN.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Install::CPAN;
+
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 our @EXPORT = qw(
     BZ_LIB

Bugzilla/Install/DB.pm

@@ -10,6 +10,7 @@ package Bugzilla::Install::DB;
 # NOTE: This package may "use" any modules that it likes,
 # localconfig is available, and params are up to date. 
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Install/Filesystem.pm

@@ -15,6 +15,7 @@ package Bugzilla::Install::Filesystem;
 # * Files do not have the correct permissions.
 # * The database does not exist.
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Install/Localconfig.pm

@@ -15,6 +15,7 @@ package Bugzilla::Install::Localconfig;
 # * Files do not have the correct permissions
 # * The database is not up to date
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Install/Requirements.pm

@@ -13,6 +13,7 @@ package Bugzilla::Install::Requirements;
 # Subroutines may "require" and "import" from modules, but they
 # MUST NOT "use."
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Install/Util.pm

@@ -11,6 +11,7 @@ package Bugzilla::Install::Util;
 # module may require *only* Bugzilla::Constants and built-in
 # perl modules.
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Job/Mailer.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Job::Mailer;
+
+use 5.10.1;
 use strict;
+
 use Bugzilla::Mailer;
 BEGIN { eval "use base qw(TheSchwartz::Worker)"; }
 

Bugzilla/JobQueue.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::JobQueue;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/JobQueue/Runner.pm

@@ -11,7 +11,9 @@
 
 package Bugzilla::JobQueue::Runner;
 
+use 5.10.1;
 use strict;
+
 use Cwd qw(abs_path);
 use File::Basename;
 use File::Copy;

Bugzilla/Keyword.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Keyword;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Error;

Bugzilla/Mailer.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Mailer;
 
+use 5.10.1;
 use strict;
 
 use base qw(Exporter);

Bugzilla/Migrate.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Migrate;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Attachment;
@@ -16,7 +18,7 @@ use Bugzilla::Error;
 use Bugzilla::Install::Requirements ();
 use Bugzilla::Install::Util qw(indicate_progress);
 use Bugzilla::Product;
-use Bugzilla::Util qw(get_text trim generate_random_password say);
+use Bugzilla::Util qw(get_text trim generate_random_password);
 use Bugzilla::User ();
 use Bugzilla::Status ();
 use Bugzilla::Version;

Bugzilla/Migrate/Gnats.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Migrate::Gnats;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Migrate);
 
 use Bugzilla::Constants;

Bugzilla/Milestone.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Milestone;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/Object.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Object;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Constants;
 use Bugzilla::Hook;
 use Bugzilla::Util;

Bugzilla/Product.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Product;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/RNG.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::RNG;
+
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 use Bugzilla::Constants qw(ON_WINDOWS);
 

Bugzilla/Report.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Report;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::CGI;

Bugzilla/Search.pm

@@ -5,9 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+package Bugzilla::Search;
+
+use 5.10.1;
 use strict;
 
-package Bugzilla::Search;
 use base qw(Exporter);
 @Bugzilla::Search::EXPORT = qw(
     IsValidQueryType

Bugzilla/Search/Clause.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Search::Clause;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Error;

Bugzilla/Search/Condition.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Search::Condition;
+
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 our @EXPORT_OK = qw(condition);
 

Bugzilla/Search/Quicksearch.pm

@@ -7,7 +7,7 @@
 
 package Bugzilla::Search::Quicksearch;
 
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
 
 use Bugzilla::Error;

Bugzilla/Search/Recent.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Search::Recent;
+
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/Search/Saved.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Search::Saved;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::CGI;

Bugzilla/Send/Sendmail.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Send::Sendmail;
 
+use 5.10.1;
 use strict;
 
 use base qw(Email::Send::Sendmail);

Bugzilla/Series.pm

@@ -5,8 +5,6 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 # This module implements a series - a set of data to be plotted on a chart.
 #
 # This Series is in the database if and only if self->{'series_id'} is defined. 
@@ -16,6 +14,9 @@ use strict;
 
 package Bugzilla::Series;
 
+use 5.10.1;
+use strict;
+
 use Bugzilla::Error;
 use Bugzilla::Util;
 

Bugzilla/Status.pm

@@ -5,11 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Status;
 
-use Bugzilla::Error;
+use 5.10.1;
+use strict;
+
 # This subclasses Bugzilla::Field::Choice instead of implementing 
 # ChoiceInterface, because a bug status literally is a special type
 # of Field::Choice, not just an object that happens to have the same
@@ -23,6 +23,8 @@ use base qw(Bugzilla::Field::Choice Exporter);
     closed_bug_statuses
 );
 
+use Bugzilla::Error;
+
 ################################
 #####   Initialization     #####
 ################################

Bugzilla/Template.pm

@@ -8,6 +8,7 @@
 
 package Bugzilla::Template;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/Template/Context.pm

@@ -7,7 +7,10 @@
 
 # This exists to implement the template-before_process hook.
 package Bugzilla::Template::Context;
+
+use 5.10.1;
 use strict;
+
 use base qw(Template::Context);
 
 use Bugzilla::Hook;

Bugzilla/Template/Plugin/Bugzilla.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Template::Plugin::Bugzilla;
 
+use 5.10.1;
 use strict;
 
 use base qw(Template::Plugin);

Bugzilla/Template/Plugin/Hook.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::Template::Plugin::Hook;
+
+use 5.10.1;
 use strict;
+
 use base qw(Template::Plugin);
 
 use Bugzilla::Constants;

Bugzilla/Token.pm

@@ -5,16 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Module Initialization
-################################################################################
+package Bugzilla::Token;
 
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
 
-# Bundle the functions in this file together into the "Bugzilla::Token" package.
-package Bugzilla::Token;
-
 use Bugzilla::Constants;
 use Bugzilla::Error;
 use Bugzilla::Mailer;

Bugzilla/Update.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Update;
 
+use 5.10.1;
 use strict;
 
 use Bugzilla::Constants;

Bugzilla/User.pm

@@ -5,16 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Module Initialization
-################################################################################
+package Bugzilla::User;
 
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
 
-# This module implements utilities for dealing with Bugzilla users.
-package Bugzilla::User;
-
 use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Constants;

Bugzilla/User/Setting.pm

@@ -8,7 +8,9 @@
 
 package Bugzilla::User::Setting;
 
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 
 

Bugzilla/User/Setting/Lang.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::User::Setting::Lang;
 
+use 5.10.1;
 use strict;
 
 use base qw(Bugzilla::User::Setting);

Bugzilla/User/Setting/Skin.pm

@@ -8,6 +8,7 @@
 
 package Bugzilla::User::Setting::Skin;
 
+use 5.10.1;
 use strict;
 
 use base qw(Bugzilla::User::Setting);

Bugzilla/User/Setting/Timezone.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::User::Setting::Timezone;
 
+use 5.10.1;
 use strict;
 
 use DateTime::TimeZone;

Bugzilla/UserAgent.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::UserAgent;
 
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 our @EXPORT = qw(detect_platform detect_op_sys);
 

Bugzilla/Util.pm

@@ -7,8 +7,8 @@
 
 package Bugzilla::Util;
 
+use 5.10.1;
 use strict;
-use feature ':5.10';
 
 use base qw(Exporter);
 @Bugzilla::Util::EXPORT = qw(trick_taint detaint_natural detaint_signed
@@ -16,7 +16,7 @@ use base qw(Exporter);
                              css_class_quote html_light_quote
                              i_am_cgi correct_urlbase remote_ip validate_ip
                              do_ssl_redirect_if_required use_attachbase
-                             diff_arrays on_main_db say
+                             diff_arrays on_main_db
                              trim wrap_hard wrap_comment find_wrap_point
                              format_time validate_date validate_time datetime_from
                              is_7bit_clean bz_crypt generate_random_password

Bugzilla/Version.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Version;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Install::Util qw(vers_cmp);

Bugzilla/WebService.pm

@@ -8,7 +8,10 @@
 # This is the base class for $self in WebService method calls. For the 
 # actual RPC server, see Bugzilla::WebService::Server and its subclasses.
 package Bugzilla::WebService;
+
+use 5.10.1;
 use strict;
+
 use Bugzilla::WebService::Server;
 
 # Used by the JSON-RPC server to convert incoming date fields apprpriately.

Bugzilla/WebService/Bug.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Bug;
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::WebService);
 
 use Bugzilla::Comment;

Bugzilla/WebService/Bugzilla.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Bugzilla;
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::WebService);
 use Bugzilla::Constants;
 use Bugzilla::Util qw(datetime_from);

Bugzilla/WebService/Constants.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Constants;
 
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 
 our @EXPORT = qw(

Bugzilla/WebService/Group.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Group;
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::WebService);
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/WebService/Product.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Product;
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::WebService);
 use Bugzilla::Product;
 use Bugzilla::User;

Bugzilla/WebService/Server.pm

@@ -6,6 +6,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::WebService::Server;
+
+use 5.10.1;
 use strict;
 
 use Bugzilla::Error;

Bugzilla/WebService/Server/JSONRPC.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Server::JSONRPC;
 
+use 5.10.1;
 use strict;
+
 use Bugzilla::WebService::Server;
 BEGIN {
     our @ISA = qw(Bugzilla::WebService::Server);

Bugzilla/WebService/Server/XMLRPC.pm

@@ -7,7 +7,9 @@
 
 package Bugzilla::WebService::Server::XMLRPC;
 
+use 5.10.1;
 use strict;
+
 use XMLRPC::Transport::HTTP;
 use Bugzilla::WebService::Server;
 if ($ENV{MOD_PERL}) {
@@ -66,7 +68,10 @@ sub handle_login {
 # This exists to validate input parameters (which XMLRPC::Lite doesn't do)
 # and also, in some cases, to more-usefully decode them.
 package Bugzilla::XMLRPC::Deserializer;
+
+use 5.10.1;
 use strict;
+
 # We can't use "use base" because XMLRPC::Serializer doesn't return
 # a true value.
 use XMLRPC::Lite;
@@ -161,7 +166,10 @@ sub _validation_subs {
 1;
 
 package Bugzilla::XMLRPC::SOM;
+
+use 5.10.1;
 use strict;
+
 use XMLRPC::Lite;
 our @ISA = qw(XMLRPC::SOM);
 use Bugzilla::WebService::Util qw(taint_data);
@@ -184,8 +192,11 @@ sub paramsin {
 # This package exists to fix a UTF-8 bug in SOAP::Lite.
 # See http://rt.cpan.org/Public/Bug/Display.html?id=32952.
 package Bugzilla::XMLRPC::Serializer;
-use Scalar::Util qw(blessed);
+
+use 5.10.1;
 use strict;
+
+use Scalar::Util qw(blessed);
 # We can't use "use base" because XMLRPC::Serializer doesn't return
 # a true value.
 use XMLRPC::Lite;

Bugzilla/WebService/User.pm

@@ -7,10 +7,11 @@
 
 package Bugzilla::WebService::User;
 
+use 5.10.1;
 use strict;
+
 use base qw(Bugzilla::WebService);
 
-use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Error;
 use Bugzilla::Group;

Bugzilla/WebService/Util.pm

@@ -6,7 +6,10 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::WebService::Util;
+
+use 5.10.1;
 use strict;
+
 use base qw(Exporter);
 
 # We have to "require", not "use" this, because otherwise it tries to

Bugzilla/Whine.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Whine;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Constants;

Bugzilla/Whine/Query.pm

@@ -7,6 +7,7 @@
 
 package Bugzilla::Whine::Query;
 
+use 5.10.1;
 use strict;
 
 use base qw(Bugzilla::Object);

Bugzilla/Whine/Schedule.pm

@@ -5,10 +5,11 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-use strict;
-
 package Bugzilla::Whine::Schedule;
 
+use 5.10.1;
+use strict;
+
 use base qw(Bugzilla::Object);
 
 use Bugzilla::Constants;

admin.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

attachment.cgi

@@ -6,13 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Script Initialization
-################################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;
@@ -24,11 +19,9 @@ use Bugzilla::FlagType;
 use Bugzilla::User;
 use Bugzilla::Util;
 use Bugzilla::Bug;
-use Bugzilla::Field;
 use Bugzilla::Attachment;
 use Bugzilla::Attachment::PatchReader;
 use Bugzilla::Token;
-use Bugzilla::Keyword;
 
 use Encode qw(encode find_encoding);
 
@@ -40,10 +33,6 @@ local our $cgi = Bugzilla->cgi;
 local our $template = Bugzilla->template;
 local our $vars = {};
 
-################################################################################
-# Main Body Execution
-################################################################################
-
 # All calls to this script should contain an "action" variable whose
 # value determines what the user wants to do.  The code below checks
 # the value of that variable and runs the appropriate code. If none is

buglist.cgi

@@ -6,13 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Script Initialization
-################################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

chart.cgi

@@ -27,6 +27,7 @@
 # Bonus:
 # Offer subscription when you get a "series already exists" error?
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
@@ -37,7 +38,6 @@ use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Chart;
 use Bugzilla::Series;
-use Bugzilla::User;
 use Bugzilla::Token;
 
 # For most scripts we don't make $cgi and $template global variables. But

colchange.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
@@ -15,7 +16,6 @@ use Bugzilla::Util;
 use Bugzilla::CGI;
 use Bugzilla::Search::Saved;
 use Bugzilla::Error;
-use Bugzilla::User;
 use Bugzilla::Token;
 
 use Storable qw(dclone);

collectstats.pl

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

config.cgi

@@ -6,13 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Script Initialization
-################################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

contrib/Bugzilla.pm

@@ -4,6 +4,7 @@
 
 package Bugzilla;
 
+use 5.10.1;
 use strict;
 
 #######################################################################

createaccount.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

describecomponents.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

describekeywords.cgi

@@ -6,12 +6,12 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
 use Bugzilla;
 use Bugzilla::Error;
-use Bugzilla::User;
 use Bugzilla::Keyword;
 
 my $user = Bugzilla->login();

docs/lib/Pod/Simple/HTML/Bugzilla.pm

@@ -7,7 +7,9 @@
 
 package Pod::Simple::HTML::Bugzilla;
 
+use 5.10.1;
 use strict;
+
 use base qw(Pod::Simple::HTML);
 
 # Without this constant, HTMLBatch will throw undef warnings.

docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm

@@ -7,7 +7,9 @@
 
 package Pod::Simple::HTMLBatch::Bugzilla;
 
+use 5.10.1;
 use strict;
+
 use base qw(Pod::Simple::HTMLBatch);
 
 # This is the same hack that HTMLBatch does to "import" this subroutine.

docs/makedocs.pl

@@ -8,7 +8,9 @@
 
 # This script compiles all the documentation.
 
+use 5.10.1;
 use strict;
+
 use Cwd;
 
 # We need to be in this directory to use our libraries.
@@ -87,8 +89,8 @@ sub MakeDocs {
 
     my ($name, $cmdline) = @_;
 
-    print "Creating $name documentation ...\n" if defined $name;
-    print "$cmdline\n\n";
+    say "Creating $name documentation ..." if defined $name;
+    say "$cmdline\n";
     system $cmdline;
     print "\n";
 
@@ -96,7 +98,7 @@ sub MakeDocs {
 
 sub make_pod {
 
-    print "Creating API documentation...\n";
+    say "Creating API documentation...";
 
     my $converter = Pod::Simple::HTMLBatch::Bugzilla->new;
     # Don't output progress information.

duplicates.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editclassifications.cgi

@@ -7,6 +7,7 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editcomponents.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editfields.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editflagtypes.cgi

@@ -6,15 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Script Initialization
-################################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
-# Use Bugzilla's flag modules for handling flag types.
 use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Flag;

editgroups.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editkeywords.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editmilestones.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editparams.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editproducts.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editsettings.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editusers.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editvalues.cgi

@@ -10,6 +10,7 @@
 # or select boxes. It is largely a copy of editmilestones.cgi, but 
 # with some cleanup.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editversions.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

editwhines.cgi

@@ -10,8 +10,8 @@
 # Script Initialization
 ################################################################################
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

editworkflow.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

email_in.pl

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use warnings;
 

enter_bug.cgi

@@ -16,8 +16,8 @@
 #
 ##############################################################################
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

extensions/create.pl

@@ -6,8 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
+
 use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Error;
@@ -54,7 +56,7 @@ foreach my $template_file (keys %create_files) {
    close($fh);
 }
 
-print get_text('extension_created', $vars), "\n";
+say get_text('extension_created', $vars);
 
 __END__
 

importxml.pl

@@ -10,6 +10,7 @@
 # a new bug into bugzilla. Everything before the beginning <?xml line
 # is removed so you can pipe in email messages.
 
+use 5.10.1;
 use strict;
 
 #####################################################################

index.cgi

@@ -6,14 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-###############################################################################
-# Script Initialization
-###############################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
-
-# Include the Bugzilla CGI and general utility library.
 use lib qw(. lib);
 
 use Bugzilla;
@@ -37,10 +31,6 @@ if ($cgi->param('logout')) {
     $cgi->delete('logout');
 }
 
-###############################################################################
-# Main Body Execution
-###############################################################################
-
 # Return the appropriate HTTP response headers.
 print $cgi->header();
 

install-module.pl

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use warnings;
 

jobqueue.pl

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 
 use Cwd qw(abs_path);

jsonrpc.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

migrate.pl

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use File::Basename;
 BEGIN { chdir dirname($0); }

mod_perl.pl

@@ -7,6 +7,8 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Bugzilla::ModPerl;
+
+use 5.10.1;
 use strict;
 use warnings;
 
@@ -107,7 +109,10 @@ foreach my $file (glob "$cgi_path/*.cgi") {
 }
 
 package Bugzilla::ModPerl::ResponseHandler;
+
+use 5.10.1;
 use strict;
+
 use base qw(ModPerl::Registry);
 use Bugzilla;
 
@@ -132,7 +137,10 @@ sub handler : method {
 
 
 package Bugzilla::ModPerl::CleanupHandler;
+
+use 5.10.1;
 use strict;
+
 use Apache2::Const -compile => qw(OK);
 
 sub handler {

page.cgi

@@ -13,8 +13,8 @@
 # a content-type, e.g. html.
 ###############################################################################
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

post_bug.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
@@ -17,11 +18,7 @@ use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;
 use Bugzilla::User;
-use Bugzilla::Field;
 use Bugzilla::Hook;
-use Bugzilla::Product;
-use Bugzilla::Component;
-use Bugzilla::Keyword;
 use Bugzilla::Token;
 use Bugzilla::Flag;
 

process_bug.cgi

@@ -18,8 +18,8 @@
 # 3) If we are processing just the one id, then it is stored in @idlist for
 # later processing.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

query.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

quips.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

relogin.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

report.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

reports.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

request.cgi

@@ -6,13 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-################################################################################
-# Script Initialization
-################################################################################
-
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;
@@ -34,10 +29,6 @@ my $action = $cgi->param('action') || '';
 
 print $cgi->header();
 
-################################################################################
-# Main Body Execution
-################################################################################
-
 my $fields;
 $fields->{'requester'}->{'type'} = 'single';
 # If the user doesn't restrict his search to requests from the wind

runtests.pl

@@ -6,7 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-# Make it harder for us to do dangerous things in Perl.
+use 5.10.1;
 use diagnostics;
 use strict;
 use lib qw(lib);

sanitycheck.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

sanitycheck.pl

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

search_plugin.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

show_activity.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

show_bug.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

showdependencygraph.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use File::Temp;

showdependencytree.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

summarize_time.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Date::Parse;         # strptime

t/002goodperl.t

@@ -16,7 +16,7 @@ use lib 't';
 
 use Support::Files;
 
-use Test::More tests => (scalar(@Support::Files::testitems) * 3);
+use Test::More tests => (scalar(@Support::Files::testitems) * 4);
 
 my @testitems = @Support::Files::testitems; # get the files to test.
 
@@ -84,6 +84,28 @@ foreach my $file (@testitems) {
     }
 }
 
+foreach my $file (@testitems) {
+    my $found_use_feature = 0;
+    $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
+    next if (!$file); # skip null entries
+    if (! open (FILE, $file)) {
+        ok(0,"could not open $file --WARNING");
+        next;
+    }
+    while (my $file_line = <FILE>) {
+        if ($file_line =~ m/^\s*use 5.10.1/) {
+            $found_use_feature = 1;
+            last;
+        }
+    }
+    close (FILE);
+    if ($found_use_feature) {
+        ok(1,"$file requires Perl 5.10.1");
+    } else {
+        ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING");
+    }
+}
+
 # Check to see that all error messages use tags (for l10n reasons.)
 foreach my $file (@testitems) {
     $file =~ s/\s.*$//; # nuke everything after the first space (#comment)

testagent.cgi

@@ -10,7 +10,9 @@
 # are being run instead of shown. This script does not rely on database access
 # or correct params.
 
+use 5.10.1;
 use strict;
-print "content-type:text/plain\n\n";
-print "OK " . ($::ENV{MOD_PERL} || "mod_cgi") . "\n";
+
+say "content-type:text/plain\n";
+say "OK " . ($::ENV{MOD_PERL} || "mod_cgi");
 exit;

testserver.pl

@@ -10,12 +10,12 @@
 # as its only argument.  It attempts to troubleshoot as many installation
 # issues as possible.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Util qw(say);
 
 use Socket;
 

token.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

userprefs.cgi

@@ -6,8 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

votes.cgi

@@ -9,8 +9,10 @@
 # This script remains as a backwards-compatibility URL for before
 # the time that Voting was an extension.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
+
 use Bugzilla;
 use Bugzilla::Error;
 

whine.pl

@@ -10,8 +10,8 @@
 # Script Initialization
 ################################################################################
 
+use 5.10.1;
 use strict;
-
 use lib qw(. lib);
 
 use Bugzilla;

whineatnews.pl

@@ -14,6 +14,7 @@
 # param. (We have NEW and REOPENED in there to keep compatibility with old
 # Bugzillas.)
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);
 

xmlrpc.cgi

@@ -6,6 +6,7 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use lib qw(. lib);