Commit 1da51538 authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 7233: Editversions.cgi has a potential race resulting in duplicate versions…

Bug 7233: Editversions.cgi has a potential race resulting in duplicate versions - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
parent 0041d80a
...@@ -455,9 +455,13 @@ use constant ABSTRACT_SCHEMA => { ...@@ -455,9 +455,13 @@ use constant ABSTRACT_SCHEMA => {
versions => { versions => {
FIELDS => [ FIELDS => [
value => {TYPE => 'TINYTEXT'}, value => {TYPE => 'varchar(64)', NOTNULL => 1},
product_id => {TYPE => 'INT2', NOTNULL => 1}, product_id => {TYPE => 'INT2', NOTNULL => 1},
], ],
INDEXES => [
versions_product_id_idx => {FIELDS => [qw(product_id value)],
TYPE => 'UNIQUE'},
],
}, },
milestones => { milestones => {
......
...@@ -3937,6 +3937,13 @@ $dbh->bz_add_index('flags', 'flags_type_id_idx', [qw(type_id)]); ...@@ -3937,6 +3937,13 @@ $dbh->bz_add_index('flags', 'flags_type_id_idx', [qw(type_id)]);
# For a short time, the flags_type_id_idx was misnamed in upgraded installs. # For a short time, the flags_type_id_idx was misnamed in upgraded installs.
$dbh->bz_drop_index('flags', 'type_id'); $dbh->bz_drop_index('flags', 'type_id');
# 2005-04-28 - LpSolit@gmail.com - Bug 7233: add an index to versions
$dbh->bz_alter_column('versions', 'value',
{TYPE => 'varchar(64)', NOTNULL => 1});
$dbh->bz_add_index('versions', 'versions_product_id_idx',
{TYPE => 'UNIQUE', FIELDS => [qw(product_id value)]});
# If you had to change the --TABLE-- definition in any way, then add your # If you had to change the --TABLE-- definition in any way, then add your
# differential change code *** A B O V E *** this comment. # differential change code *** A B O V E *** this comment.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment