Skip to content

bugzilla
bugzilla
Commit 4dba1879 authored by Frédéric Buclin's avatar Frédéric Buclin
Browse files
Options

Bug 1111043: Bug.add_comment returns the wrong comment ID

r/a=dkl
parent d1634d5e
Show whitespace changes
Inline Side-by-side
Showing with 1 addition and 10 deletions
Bugzilla/WebService/Bug.pm
View file @ 4dba1879
...@@ -707,18 +707,9 @@ sub add_comment { ...@@ -707,18 +707,9 @@ sub add_comment {
# Append comment # Append comment
$bug->add_comment($comment, { isprivate => $params->{is_private}, $bug->add_comment($comment, { isprivate => $params->{is_private},
work_time => $params->{work_time} }); work_time => $params->{work_time} });
# Capture the call to bug->update (which creates the new comment) in
# a transaction so we're sure to get the correct comment_id.
my $dbh = Bugzilla->dbh;
$dbh->bz_start_transaction();
$bug->update(); $bug->update();
my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id'); my $new_comment_id = $bug->{added_comments}[0]->id;
$dbh->bz_commit_transaction();
# Send mail. # Send mail.
Bugzilla::BugMail::Send($bug->bug_id, { changer => $user }); Bugzilla::BugMail::Send($bug->bug_id, { changer => $user });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment