Commit 91f9bc0f authored by terry%mozilla.org's avatar terry%mozilla.org

Patch by Klaas Freitag <freitag@suse.de>, with modifications by me --

don't generate HTML tables with more than 50 lines, as browsers generally can't cope with huge tables.
parent 3bf8bf09
...@@ -31,7 +31,7 @@ print "Content-type: text/html\n\n"; ...@@ -31,7 +31,7 @@ print "Content-type: text/html\n\n";
PutHeader("Bugzilla keyword description"); PutHeader("Bugzilla keyword description");
print qq{ my $tableheader = qq{
<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0> <TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0>
<TR BGCOLOR="#6666FF"> <TR BGCOLOR="#6666FF">
<TH ALIGN="left">Name</TH> <TH ALIGN="left">Name</TH>
...@@ -40,6 +40,10 @@ print qq{ ...@@ -40,6 +40,10 @@ print qq{
</TR> </TR>
}; };
print $tableheader;
my $line_count = 0;
my $max_table_size = 50;
SendSQL("SELECT keyworddefs.name, keyworddefs.description, SendSQL("SELECT keyworddefs.name, keyworddefs.description,
COUNT(keywords.bug_id), keywords.bug_id COUNT(keywords.bug_id), keywords.bug_id
FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id=keywords.keywordid FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id=keywords.keywordid
...@@ -59,6 +63,11 @@ while (MoreSQLData()) { ...@@ -59,6 +63,11 @@ while (MoreSQLData()) {
} else { } else {
$bugs = "none"; $bugs = "none";
} }
if ($line_count == $max_table_size) {
print "</table>\n$tableheader";
$line_count = 0;
}
$line_count++;
print qq{ print qq{
<TR> <TR>
<TH>$name</TH> <TH>$name</TH>
......
...@@ -125,7 +125,7 @@ my $action = trim($::FORM{action} || ''); ...@@ -125,7 +125,7 @@ my $action = trim($::FORM{action} || '');
if ($action eq "") { if ($action eq "") {
PutHeader("Select keyword"); PutHeader("Select keyword");
print qq{ my $tableheader = qq{
<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0> <TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0>
<TR BGCOLOR="#6666FF"> <TR BGCOLOR="#6666FF">
<TH ALIGN="left">Edit keyword ...</TH> <TH ALIGN="left">Edit keyword ...</TH>
...@@ -134,6 +134,10 @@ if ($action eq "") { ...@@ -134,6 +134,10 @@ if ($action eq "") {
<TH ALIGN="left">Action</TH> <TH ALIGN="left">Action</TH>
</TR> </TR>
}; };
print $tableheader;
my $line_count = 0;
my $max_table_size = 50;
SendSQL("SELECT keyworddefs.id, keyworddefs.name, keyworddefs.description, SendSQL("SELECT keyworddefs.id, keyworddefs.name, keyworddefs.description,
COUNT(keywords.bug_id), keywords.bug_id COUNT(keywords.bug_id), keywords.bug_id
FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id = keywords.keywordid FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id = keywords.keywordid
...@@ -151,6 +155,12 @@ if ($action eq "") { ...@@ -151,6 +155,12 @@ if ($action eq "") {
# what it had responded. # what it had responded.
$bugs = 'none'; $bugs = 'none';
} }
if ($line_count == $max_table_size) {
print "</table>\n$tableheader";
$line_count = 0;
}
$line_count++;
print qq{ print qq{
<TR> <TR>
<TH VALIGN="top"><A HREF="editkeywords.cgi?action=edit&id=$id">$name</TH> <TH VALIGN="top"><A HREF="editkeywords.cgi?action=edit&id=$id">$name</TH>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment