Bug 996893: Perl 5.18 and newer throw tons of warnings about deprecated modules

Bugzilla.pm

@@ -9,6 +9,7 @@ package Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 # We want any compile errors to get to the browser, if possible.
 BEGIN {

Bugzilla/Attachment.pm

@@ -9,6 +9,7 @@ package Bugzilla::Attachment;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 =head1 NAME
 

Bugzilla/Attachment/PatchReader.pm

@@ -9,6 +9,7 @@ package Bugzilla::Attachment::PatchReader;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Config;
 use IO::Select;

Bugzilla/Auth.pm

@@ -9,6 +9,8 @@ package Bugzilla::Auth;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use fields qw(
     _info_getter
     _verifier

Bugzilla/Auth/Login.pm

@@ -9,6 +9,8 @@ package Bugzilla::Auth::Login;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use fields qw();
 
 # Determines whether or not a user can logout. It's really a subroutine,

Bugzilla/Auth/Login/APIKey.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Login::APIKey;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use base qw(Bugzilla::Auth::Login);
 

Bugzilla/Auth/Login/CGI.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Login::CGI;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Auth::Login);
 use constant user_can_create_account => 1;

Bugzilla/Auth/Login/Cookie.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Login::Cookie;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use base qw(Bugzilla::Auth::Login);
 use fields qw(_login_token);

Bugzilla/Auth/Login/Env.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Login::Env;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Auth::Login);
 

Bugzilla/Auth/Login/Stack.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Login::Stack;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use base qw(Bugzilla::Auth::Login);
 use fields qw(

Bugzilla/Auth/Persist/Cookie.pm

@@ -9,6 +9,8 @@ package Bugzilla::Auth::Persist::Cookie;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use fields qw();
 
 use Bugzilla::Constants;

Bugzilla/Auth/Verify.pm

@@ -9,6 +9,8 @@ package Bugzilla::Auth::Verify;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use fields qw();
 
 use Bugzilla::Constants;

Bugzilla/Auth/Verify/DB.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Verify::DB;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Auth::Verify);
 

Bugzilla/Auth/Verify/LDAP.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Verify::LDAP;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use base qw(Bugzilla::Auth::Verify);
 use fields qw(

Bugzilla/Auth/Verify/RADIUS.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Verify::RADIUS;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Auth::Verify);
 

Bugzilla/Auth/Verify/Stack.pm

@@ -9,6 +9,7 @@ package Bugzilla::Auth::Verify::Stack;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use base qw(Bugzilla::Auth::Verify);
 use fields qw(

Bugzilla/Bug.pm

@@ -9,6 +9,7 @@ package Bugzilla::Bug;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Attachment;
 use Bugzilla::Constants;

Bugzilla/BugMail.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugMail;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::User;

Bugzilla/BugUrl.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/BugUrl/Bugzilla.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/Bugzilla/Local.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Bugzilla::Local;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl::Bugzilla);
 

Bugzilla/BugUrl/Debian.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Debian;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/GitHub.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::GitHub;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/Google.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Google;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/JIRA.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::JIRA;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/Launchpad.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Launchpad;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/MantisBT.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::MantisBT;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/SourceForge.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::SourceForge;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUrl/Trac.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUrl::Trac;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::BugUrl);
 

Bugzilla/BugUserLastVisit.pm

@@ -9,6 +9,7 @@ package Bugzilla::BugUserLastVisit;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/CGI.pm

@@ -9,6 +9,7 @@ package Bugzilla::CGI;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(CGI);
 

Bugzilla/Chart.pm

@@ -15,6 +15,7 @@ package Bugzilla::Chart;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Util;

Bugzilla/Classification.pm

@@ -9,6 +9,7 @@ package Bugzilla::Classification;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Field;

Bugzilla/Comment.pm

@@ -9,6 +9,7 @@ package Bugzilla::Comment;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Comment/TagWeights.pm

@@ -9,6 +9,7 @@ package Bugzilla::Comment::TagWeights;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Component.pm

@@ -9,6 +9,7 @@ package Bugzilla::Component;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 

Bugzilla/Config.pm

@@ -9,8 +9,10 @@ package Bugzilla::Config;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
+
 use Bugzilla::Constants;
 use Bugzilla::Hook;
 use Data::Dumper;

Bugzilla/Config/Admin.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Admin;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/Advanced.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Advanced;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/Attachment.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Attachment;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/Auth.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Auth;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/BugChange.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::BugChange;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 use Bugzilla::Status;

Bugzilla/Config/BugFields.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::BugFields;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 use Bugzilla::Field;

Bugzilla/Config/Common.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Common;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Email::Address;
 use Socket;

Bugzilla/Config/Core.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Core;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/DependencyGraph.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::DependencyGraph;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/General.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::General;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/GroupSecurity.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::GroupSecurity;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 use Bugzilla::Group;

Bugzilla/Config/LDAP.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::LDAP;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/MTA.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::MTA;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 # Return::Value 1.666002 pollutes the error log with warnings about this

Bugzilla/Config/Memcached.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Memcached;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/PatchViewer.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::PatchViewer;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/Query.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::Query;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/RADIUS.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::RADIUS;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/ShadowDB.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::ShadowDB;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Config/UserMatch.pm

@@ -9,6 +9,7 @@ package Bugzilla::Config::UserMatch;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

Bugzilla/Constants.pm

@@ -9,6 +9,7 @@ package Bugzilla::Constants;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 

Bugzilla/DB.pm

@@ -9,6 +9,7 @@ package Bugzilla::DB;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use DBI;
 

Bugzilla/DB/Mysql.pm

@@ -23,6 +23,7 @@ package Bugzilla::DB::Mysql;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB);
 

Bugzilla/DB/Oracle.pm

@@ -23,6 +23,7 @@ package Bugzilla::DB::Oracle;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB);
 
@@ -721,6 +722,7 @@ package Bugzilla::DB::Oracle::st;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent -norequire, qw(DBI::st);
  

Bugzilla/DB/Pg.pm

@@ -23,6 +23,7 @@ package Bugzilla::DB::Pg;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Version;

Bugzilla/DB/Schema.pm

@@ -17,6 +17,7 @@ package Bugzilla::DB::Schema;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Hook;

Bugzilla/DB/Schema/Mysql.pm

@@ -15,6 +15,7 @@ package Bugzilla::DB::Schema::Mysql;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 

Bugzilla/DB/Schema/Oracle.pm

@@ -15,6 +15,7 @@ package Bugzilla::DB::Schema::Oracle;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB::Schema);
 use Carp qw(confess);

Bugzilla/DB/Schema/Pg.pm

@@ -15,6 +15,7 @@ package Bugzilla::DB::Schema::Pg;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB::Schema);
 use Storable qw(dclone);

Bugzilla/DB/Schema/Sqlite.pm

@@ -9,6 +9,7 @@ package Bugzilla::DB::Schema::Sqlite;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB::Schema);
 

Bugzilla/DB/Sqlite.pm

@@ -9,6 +9,7 @@ package Bugzilla::DB::Sqlite;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::DB);
 

Bugzilla/Error.pm

@@ -9,6 +9,7 @@ package Bugzilla::Error;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 

Bugzilla/Extension.pm

@@ -9,6 +9,7 @@ package Bugzilla::Extension;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/Field.pm

@@ -59,6 +59,7 @@ package Bugzilla::Field;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter Bugzilla::Object);
 @Bugzilla::Field::EXPORT = qw(check_field get_field_id get_legal_field_values);

Bugzilla/Field/Choice.pm

@@ -9,6 +9,7 @@ package Bugzilla::Field::Choice;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 

Bugzilla/Field/ChoiceInterface.pm

@@ -9,6 +9,7 @@ package Bugzilla::Field::ChoiceInterface;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/Flag.pm

@@ -9,6 +9,7 @@ package Bugzilla::Flag;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 =head1 NAME
 

Bugzilla/FlagType.pm

@@ -9,6 +9,7 @@ package Bugzilla::FlagType;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 =head1 NAME
 

Bugzilla/Group.pm

@@ -9,6 +9,7 @@ package Bugzilla::Group;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Hook.pm

@@ -9,6 +9,7 @@ package Bugzilla::Hook;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 sub process {
     my ($name, $args) = @_;

Bugzilla/Install.pm

@@ -17,6 +17,7 @@ package Bugzilla::Install;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Component;
 use Bugzilla::Config qw(:admin);

Bugzilla/Install/CPAN.pm

@@ -9,6 +9,7 @@ package Bugzilla::Install::CPAN;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 our @EXPORT = qw(

Bugzilla/Install/DB.pm

@@ -12,6 +12,7 @@ package Bugzilla::Install::DB;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Hook;

Bugzilla/Install/Filesystem.pm

@@ -17,6 +17,7 @@ package Bugzilla::Install::Filesystem;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/Install/Localconfig.pm

@@ -17,6 +17,7 @@ package Bugzilla::Install::Localconfig;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Install::Util qw(bin_loc install_string);

Bugzilla/Install/Requirements.pm

@@ -15,6 +15,7 @@ package Bugzilla::Install::Requirements;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Install::Util qw(install_string bin_loc

Bugzilla/Install/Util.pm

@@ -13,6 +13,7 @@ package Bugzilla::Install::Util;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 

Bugzilla/Job/BugMail.pm

@@ -9,6 +9,7 @@ package Bugzilla::Job::BugMail;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::BugMail;
 BEGIN { eval "use parent qw(Bugzilla::Job::Mailer)"; }

Bugzilla/Job/Mailer.pm

@@ -9,6 +9,7 @@ package Bugzilla::Job::Mailer;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Mailer;
 BEGIN { eval "use parent qw(TheSchwartz::Worker)"; }

Bugzilla/JobQueue.pm

@@ -9,6 +9,7 @@ package Bugzilla::JobQueue;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/JobQueue/Runner.pm

@@ -13,6 +13,7 @@ package Bugzilla::JobQueue::Runner;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Cwd qw(abs_path);
 use File::Basename;

Bugzilla/Keyword.pm

@@ -9,6 +9,7 @@ package Bugzilla::Keyword;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Mailer.pm

@@ -9,6 +9,7 @@ package Bugzilla::Mailer;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 @Bugzilla::Mailer::EXPORT = qw(MessageToMTA build_thread_marker);

Bugzilla/Migrate.pm

@@ -9,6 +9,7 @@ package Bugzilla::Migrate;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Attachment;
 use Bugzilla::Bug qw(LogActivityEntry);

Bugzilla/Migrate/Gnats.pm

@@ -9,6 +9,7 @@ package Bugzilla::Migrate::Gnats;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Migrate);
 

Bugzilla/Milestone.pm

@@ -9,6 +9,7 @@ package Bugzilla::Milestone;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Object.pm

@@ -9,6 +9,7 @@ package Bugzilla::Object;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Hook;

Bugzilla/Product.pm

@@ -9,6 +9,7 @@ package Bugzilla::Product;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object);
 

Bugzilla/RNG.pm

@@ -9,6 +9,7 @@ package Bugzilla::RNG;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 use Bugzilla::Constants qw(ON_WINDOWS);

Bugzilla/Report.pm

@@ -9,6 +9,7 @@ package Bugzilla::Report;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Search.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 @Bugzilla::Search::EXPORT = qw(

Bugzilla/Search/Clause.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::Clause;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Search::Condition qw(condition);

Bugzilla/Search/ClauseGroup.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::ClauseGroup;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Search::Clause);
 

Bugzilla/Search/Condition.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::Condition;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 our @EXPORT_OK = qw(condition);

Bugzilla/Search/Quicksearch.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::Quicksearch;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Constants;

Bugzilla/Search/Recent.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::Recent;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Search/Saved.pm

@@ -9,6 +9,7 @@ package Bugzilla::Search::Saved;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Send/Sendmail.pm

@@ -9,6 +9,7 @@ package Bugzilla::Send::Sendmail;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Email::Send::Sendmail);
 

Bugzilla/Series.pm

@@ -16,6 +16,7 @@ package Bugzilla::Series;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Util;

Bugzilla/Status.pm

@@ -9,6 +9,7 @@ package Bugzilla::Status;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 # This subclasses Bugzilla::Field::Choice instead of implementing 
 # ChoiceInterface, because a bug status literally is a special type

Bugzilla/Template.pm

@@ -10,6 +10,7 @@ package Bugzilla::Template;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::WebService::Constants;

Bugzilla/Template/Context.pm

@@ -10,6 +10,7 @@ package Bugzilla::Template::Context;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Template::Context);
 

Bugzilla/Template/Plugin/Bugzilla.pm

@@ -9,6 +9,7 @@ package Bugzilla::Template::Plugin::Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Template::Plugin);
 

Bugzilla/Template/Plugin/Hook.pm

@@ -9,6 +9,7 @@ package Bugzilla::Template::Plugin::Hook;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Template::Plugin);
 

Bugzilla/Token.pm

@@ -9,6 +9,7 @@ package Bugzilla::Token;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 use Bugzilla::Error;

Bugzilla/Update.pm

@@ -9,6 +9,7 @@ package Bugzilla::Update;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Constants;
 

Bugzilla/User.pm

@@ -9,6 +9,7 @@ package Bugzilla::User;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Util;

Bugzilla/User/APIKey.pm

@@ -9,6 +9,7 @@ package Bugzilla::User::APIKey;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/User/Setting.pm

@@ -10,6 +10,7 @@ package Bugzilla::User::Setting;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 

Bugzilla/User/Setting/Lang.pm

@@ -9,6 +9,7 @@ package Bugzilla::User::Setting::Lang;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::User::Setting);
 

Bugzilla/User/Setting/Skin.pm

@@ -10,6 +10,7 @@ package Bugzilla::User::Setting::Skin;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::User::Setting);
 

Bugzilla/User/Setting/Timezone.pm

@@ -9,6 +9,7 @@ package Bugzilla::User::Setting::Timezone;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use DateTime::TimeZone;
 

Bugzilla/UserAgent.pm

@@ -9,6 +9,7 @@ package Bugzilla::UserAgent;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 our @EXPORT = qw(detect_platform detect_op_sys);

Bugzilla/Util.pm

@@ -9,6 +9,7 @@ package Bugzilla::Util;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 @Bugzilla::Util::EXPORT = qw(trick_taint detaint_natural detaint_signed

Bugzilla/Version.pm

@@ -9,6 +9,7 @@ package Bugzilla::Version;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object Exporter);
 

Bugzilla/WebService.pm

@@ -11,6 +11,7 @@ package Bugzilla::WebService;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Server;
 

Bugzilla/WebService/Bug.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Bug;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 

Bugzilla/WebService/BugUserLastVisit.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::BugUserLastVisit;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 

Bugzilla/WebService/Bugzilla.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 use Bugzilla::Constants;

Bugzilla/WebService/Classification.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Classification;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw (Bugzilla::WebService);
 

Bugzilla/WebService/Component.pm

@@ -8,8 +8,9 @@
 package Bugzilla::WebService::Component;
 
 use 5.10.1;
-
 use strict;
+use warnings;
+
 use base qw(Bugzilla::WebService);
 
 use Bugzilla::Component;

Bugzilla/WebService/Constants.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Constants;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Exporter);
 

Bugzilla/WebService/FlagType.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::FlagType;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 use Bugzilla::Component;

Bugzilla/WebService/Group.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Group;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 use Bugzilla::Constants;

Bugzilla/WebService/Product.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Product;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 use Bugzilla::Product;

Bugzilla/WebService/Server.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Error;
 use Bugzilla::Util qw(datetime_from);

Bugzilla/WebService/Server/JSONRPC.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::JSONRPC;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Server;
 BEGIN {

Bugzilla/WebService/Server/REST.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService::Server::JSONRPC);
 

Bugzilla/WebService/Server/REST/Resources/Bug.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Bug;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Bug;

Bugzilla/WebService/Server/REST/Resources/Bugzilla.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Bugzilla;

Bugzilla/WebService/Server/REST/Resources/Classification.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Classification;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Classification;

Bugzilla/WebService/Server/REST/Resources/Component.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Component;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Component;

Bugzilla/WebService/Server/REST/Resources/FlagType.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::FlagType;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::FlagType;

Bugzilla/WebService/Server/REST/Resources/Group.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Group;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Group;

Bugzilla/WebService/Server/REST/Resources/Product.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::Product;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::Product;

Bugzilla/WebService/Server/REST/Resources/User.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::REST::Resources::User;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::WebService::Constants;
 use Bugzilla::WebService::User;

Bugzilla/WebService/Server/XMLRPC.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Server::XMLRPC;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use XMLRPC::Transport::HTTP;
 use Bugzilla::WebService::Server;
@@ -107,6 +108,7 @@ package Bugzilla::XMLRPC::Deserializer;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 # We can't use "use parent" because XMLRPC::Serializer doesn't return
 # a true value.
@@ -205,6 +207,7 @@ package Bugzilla::XMLRPC::SOM;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use XMLRPC::Lite;
 our @ISA = qw(XMLRPC::SOM);
@@ -231,6 +234,7 @@ package Bugzilla::XMLRPC::Serializer;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Scalar::Util qw(blessed reftype);
 # We can't use "use parent" because XMLRPC::Serializer doesn't return

Bugzilla/WebService/User.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::User;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::WebService);
 

Bugzilla/WebService/Util.pm

@@ -9,6 +9,7 @@ package Bugzilla::WebService::Util;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Flag;
 use Bugzilla::FlagType;

Bugzilla/Whine.pm

@@ -9,6 +9,7 @@ package Bugzilla::Whine;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Whine/Query.pm

@@ -9,6 +9,7 @@ package Bugzilla::Whine::Query;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

Bugzilla/Whine/Schedule.pm

@@ -9,6 +9,7 @@ package Bugzilla::Whine::Schedule;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(Bugzilla::Object);
 

admin.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

attachment.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

buglist.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

chart.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -29,6 +29,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

checksetup.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,8 +12,10 @@
 # Initialization
 ######################################################################
 
-use strict;
 use 5.10.1;
+use strict;
+use warnings;
+
 use File::Basename;
 use Getopt::Long qw(:config bundling);
 use Pod::Usage;

clean-bug-user-last-visit.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

colchange.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

collectstats.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Getopt::Long qw(:config bundling);

config.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/Bugzilla.pm

@@ -6,6 +6,7 @@ package Bugzilla;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 #######################################################################
 # The goal of this tiny module is to let Bugzilla packagers of        #

contrib/bz_webservice_demo.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -18,7 +18,10 @@ C<bz_webservice_demo.pl --help> for detailed help
 
 =cut
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(lib);
 use Getopt::Long;
 use Pod::Usage;

contrib/bzdbcopy.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,7 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 use Bugzilla;
 use Bugzilla::Constants;

contrib/console.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,6 +6,8 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use warnings;
+
 use File::Basename;
 BEGIN { chdir dirname($0) . "/.."; }
 use lib qw(. lib);
@@ -51,7 +53,7 @@ sub d {
 
 # p: print as a single string (normal behavior puts list items on separate lines)
 sub p {
-    local $^W=0; # suppress possible undefined var message 
+    no warnings; # suppress possible undefined var message 
     print(@_, "\n");
     return ();
 }

contrib/convert-workflow.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,7 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/extension-convert.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,8 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;
@@ -68,6 +70,8 @@ my ($modules, $subs) = code_files_to_subroutines($to_dir);
 my $config_pm = <<END;
 package Bugzilla::Extension::$extension_name;
 use strict;
+use warnings;
+
 use constant NAME => '$extension_name';
 $install_requirements
 __PACKAGE__->NAME;
@@ -76,6 +80,8 @@ END
 my $extension_pm = <<END;
 package Bugzilla::Extension::$extension_name;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 $modules

contrib/fixperms.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,8 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
 use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/merge-users.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,7 +6,9 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
+use warnings;
 
 =head1 NAME
 

contrib/mysqld-watcher.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -9,7 +9,9 @@
 # mysqld-watcher.pl - a script that watches the running instance of
 # mysqld and kills off any long-running SELECTs against the shadow_db
 # 
+use 5.10.1;
 use strict;
+use warnings;
 
 # some configurables: 
 

contrib/recode.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,7 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/sendbugmail.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/sendunsentbugmail.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

contrib/syncLDAP.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,7 +6,9 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib qw(. lib);
 

createaccount.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

describecomponents.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

describekeywords.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

duplicates.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editclassifications.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -9,6 +9,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editcomponents.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editfields.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editflagtypes.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editgroups.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editkeywords.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editmilestones.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editparams.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editproducts.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editsettings.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editusers.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editvalues.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,12 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-# This is a script to edit the values of fields that have drop-down
-# or select boxes. It is largely a copy of editmilestones.cgi, but 
-# with some cleanup.
-
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editversions.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editwhines.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,6 +12,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

editworkflow.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

email_in.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

enter_bug.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -18,6 +18,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

extensions/BmpConvert/Config.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::BmpConvert;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use constant NAME => 'BmpConvert';
 use constant REQUIRED_MODULES => [
   {

extensions/BmpConvert/Extension.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::BmpConvert;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 use Image::Magick;

extensions/Example/Config.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::Example;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use constant NAME => 'Example';
 use constant REQUIRED_MODULES => [
     {

extensions/Example/Extension.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::Example;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 use Bugzilla::Constants;

extensions/Example/lib/Auth/Login.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::Example::Auth::Login;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Auth::Login);
 use constant user_can_create_account => 0;
 use Bugzilla::Constants;

extensions/Example/lib/Auth/Verify.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::Example::Auth::Verify;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Auth::Verify);
 use Bugzilla::Constants;
 

extensions/MoreBugUrl/Config.pm

@@ -9,6 +9,7 @@ package Bugzilla::Extension::MoreBugUrl;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use constant NAME => 'MoreBugUrl';
 

extensions/MoreBugUrl/Extension.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 use constant MORE_SUB_CLASSES => qw(

extensions/MoreBugUrl/lib/BitBucket.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::BitBucket;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/GetSatisfaction.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::GetSatisfaction;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/PHP.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::PHP;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/RT.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::RT;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/Redmine.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::Redmine;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/ReviewBoard.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::ReviewBoard;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/Rietveld.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::Rietveld;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/MoreBugUrl/lib/Savane.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::MoreBugUrl::Savane;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::BugUrl);
 
 ###############################

extensions/OldBugMove/Config.pm

@@ -9,5 +9,7 @@ package Bugzilla::Extension::OldBugMove;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use constant NAME => 'OldBugMove';
 __PACKAGE__->NAME;

extensions/OldBugMove/Extension.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::OldBugMove;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 use Bugzilla::Constants;
 use Bugzilla::Error;

extensions/OldBugMove/lib/Params.pm

@@ -9,6 +9,7 @@ package Bugzilla::Extension::OldBugMove::Params;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Bugzilla::Config::Common;
 

extensions/Voting/Config.pm

@@ -9,6 +9,7 @@ package Bugzilla::Extension::Voting;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use constant NAME => 'Voting';
 

extensions/Voting/Extension.pm

@@ -9,6 +9,8 @@ package Bugzilla::Extension::Voting;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 use Bugzilla::Bug;

extensions/create.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

importxml.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,6 +12,7 @@
 
 use 5.10.1;
 use strict;
+use warnings;
 
 #####################################################################
 #

index.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

install-module.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

jobqueue.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,7 @@
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Cwd qw(abs_path);
 use File::Basename;

jsonrpc.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

migrate.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use File::Basename;
 BEGIN { chdir dirname($0); }
 use lib qw(. lib);

mod_perl.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -112,6 +112,7 @@ package Bugzilla::ModPerl::ResponseHandler;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use parent qw(ModPerl::Registry);
 use Bugzilla;
@@ -148,6 +149,7 @@ package Bugzilla::ModPerl::CleanupHandler;
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use Apache2::Const -compile => qw(OK);
 

page.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -15,6 +15,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

post_bug.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

process_bug.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -6,20 +6,10 @@
 # This Source Code Form is "Incompatible With Secondary Licenses", as
 # defined by the Mozilla Public License, v. 2.0.
 
-# Implementation notes for this file:
-#
-# 1) the 'id' form parameter is validated early on, and if it is not a valid
-# bugid an error will be reported, so it is OK for later code to simply check
-# for a defined form 'id' value, and it can assume a valid bugid.
-#
-# 2) If the 'id' form parameter is not defined (after the initial validation),
-# then we are processing multiple bugs, and @idlist will contain the ids.
-#
-# 3) If we are processing just the one id, then it is stored in @idlist for
-# later processing.
-
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

query.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

quips.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

relogin.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

report.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

reports.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

request.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

rest.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

runtests.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -9,6 +9,8 @@
 use 5.10.1;
 use diagnostics;
 use strict;
+use warnings;
+
 use lib qw(lib);
 
 use Test::Harness qw(&runtests $verbose);

sanitycheck.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

sanitycheck.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

search_plugin.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

show_activity.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

show_bug.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

showdependencygraph.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use File::Temp;

showdependencytree.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

summarize_time.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Date::Parse;         # strptime

t/001compile.t

@@ -10,8 +10,10 @@
 #Bugzilla Test 1#
 ###Compilation###
 
-use strict;
 use 5.10.1;
+use strict;
+use warnings;
+
 use lib qw(. lib t);
 use Config;
 use Support::Files;
@@ -52,7 +54,7 @@ sub compile_file {
        $libs = join " ", map { "-I\"$_\"" } split /$Config{path_sep}/, $ENV{PERL5LIB};
     }
     my $perl = qq{"$^X"};
-    my $output = `$perl $libs -wc$T $file 2>&1`;
+    my $output = `$perl $libs -c$T $file 2>&1`;
     chomp($output);
     my $return_val = $?;
     $output =~ s/^\Q$file\E syntax OK$//ms;

t/002goodperl.t

@@ -10,15 +10,19 @@
 #Bugzilla Test 2#
 ####GoodPerl#####
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 
 use Support::Files;
 
-use Test::More tests => (scalar(@Support::Files::testitems) * 4);
+use Test::More tests => (scalar(@Support::Files::testitems)
+                         + scalar(@Support::Files::test_files)) * 5;
 
-my @testitems = @Support::Files::testitems; # get the files to test.
+my @testitems = (@Support::Files::test_files, @Support::Files::testitems);
+my @require_taint = qw(email_in.pl importxml.pl mod_perl.pl whine.pl);
 
 foreach my $file (@testitems) {
     $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
@@ -38,23 +42,33 @@ foreach my $file (@testitems) {
         my $flags;
         if (!defined $ext || $ext eq "pl") {
             # standalone programs aren't taint checked yet
-            $flags = "w";
+            if (grep { $file eq $_ } @require_taint) {
+                $flags = 'T';
+            }
+            else {
+                $flags = '';
+            }
         } elsif ($ext eq "pm") {
             ok(0, "$file is a module, but has a shebang");
             next;
         } elsif ($ext eq "cgi") {
             # cgi files must be taint checked
-            $flags = "wT";
+            $flags = 'T';
         } else {
             ok(0, "$file has shebang but unknown extension");
             next;
         }
 
-        if ($file_line1 =~ m#^\#\!/usr/bin/perl\s#) {
-            if ($file_line1 =~ m#\s-$flags#) {
-                ok(1,"$file uses standard perl location and -$flags");
-            } else {
-                ok(0,"$file is MISSING -$flags --WARNING");
+        if ($file_line1 =~ m#^\#\!/usr/bin/perl(?:\s-(\w+))?$#) {
+            my $file_flags = $1 || '';
+            if ($flags eq $file_flags) {
+                ok(1, "$file uses standard perl location" . ($flags ? " and -$flags flag" : ""));
+            }
+            elsif ($flags) {
+                ok(0, "$file is MISSING -$flags flag --WARNING");
+            }
+            else {
+                ok(0, "$file has unexpected -$file_flags flag --WARNING");
             }
         } else {
             ok(0,"$file uses non-standard perl location");
@@ -63,7 +77,10 @@ foreach my $file (@testitems) {
 }
 
 foreach my $file (@testitems) {
+    my $found_use_perl = 0;
     my $found_use_strict = 0;
+    my $found_use_warnings = 0;
+
     $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
     next if (!$file); # skip null entries
     if (! open (FILE, $file)) {
@@ -71,38 +88,28 @@ foreach my $file (@testitems) {
         next;
     }
     while (my $file_line = <FILE>) {
-        if ($file_line =~ m/^\s*use strict/) {
-            $found_use_strict = 1;
-            last;
-        }
+        $found_use_perl = 1 if $file_line =~ m/^\s*use 5.10.1/;
+        $found_use_strict = 1 if $file_line =~ m/^\s*use strict/;
+        $found_use_warnings = 1 if $file_line =~ m/^\s*use warnings/;
+        last if ($found_use_perl && $found_use_strict && $found_use_warnings);
     }
     close (FILE);
+    if ($found_use_perl) {
+        ok(1,"$file requires Perl 5.10.1");
+    } else {
+        ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING");
+    }
+
     if ($found_use_strict) {
         ok(1,"$file uses strict");
     } else {
         ok(0,"$file DOES NOT use strict --WARNING");
     }
-}
 
-foreach my $file (@testitems) {
-    my $found_use_feature = 0;
-    $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
-    next if (!$file); # skip null entries
-    if (! open (FILE, $file)) {
-        ok(0,"could not open $file --WARNING");
-        next;
-    }
-    while (my $file_line = <FILE>) {
-        if ($file_line =~ m/^\s*use 5.10.1/) {
-            $found_use_feature = 1;
-            last;
-        }
-    }
-    close (FILE);
-    if ($found_use_feature) {
-        ok(1,"$file requires Perl 5.10.1");
+    if ($found_use_warnings) {
+        ok(1,"$file uses warnings");
     } else {
-        ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING");
+        ok(0,"$file DOES NOT use warnings --WARNING");
     }
 }
 

t/003safesys.t

@@ -10,7 +10,9 @@
 #Bugzilla Test 3#
 ###Safesystem####
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 
@@ -22,7 +24,7 @@ use Test::More tests => scalar(@Support::Files::testitems);
 # This will handle verbosity for us automatically.
 my $fh;
 {
-    local $^W = 0;  # Don't complain about non-existent filehandles
+    no warnings qw(unopened);  # Don't complain about non-existent filehandles
     if (-e \*Test::More::TESTOUT) {
         $fh = \*Test::More::TESTOUT;
     } elsif (-e \*Test::Builder::TESTOUT) {

t/004template.t

@@ -9,7 +9,9 @@
 #Bugzilla Test 4#
 ####Templates####
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 
@@ -26,7 +28,7 @@ use Test::More tests => ( scalar(@referenced_files) + 2 * $num_actual_files );
 # This will handle verbosity for us automatically.
 my $fh;
 {
-    local $^W = 0;  # Don't complain about non-existent filehandles
+    no warnings qw(unopened);  # Don't complain about non-existent filehandles
     if (-e \*Test::More::TESTOUT) {
         $fh = \*Test::More::TESTOUT;
     } elsif (-e \*Test::Builder::TESTOUT) {

t/005whitespace.t

@@ -9,7 +9,9 @@
 #Bugzilla Test 5#
 #####no_tabs#####
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 

t/006spellcheck.t

@@ -10,29 +10,13 @@
 #Bugzilla Test 6#
 ####Spelling#####
 
+use 5.10.1;
+use strict;
+use warnings;
+
 use lib 't';
 use Support::Files;
 
-BEGIN {
-    #add the words to check here:
-    @evilwords = qw(
-        anyways
-        appearence
-        arbitary
-        cancelled
-        critera
-        databasa
-        dependan
-        existance
-        existant
-        paramater
-        refered
-        repsentation
-        suported
-        varsion
-    );
-}
-
 # -1 because 006spellcheck.t must not be checked.
 use Test::More tests => scalar(@Support::Files::testitems)
                         + scalar(@Support::Files::test_files) - 1;
@@ -41,7 +25,7 @@ use Test::More tests => scalar(@Support::Files::testitems)
 # This will handle verbosity for us automatically.
 my $fh;
 {
-    local $^W = 0;  # Don't complain about non-existent filehandles
+    no warnings qw(unopened);  # Don't complain about non-existent filehandles
     if (-e \*Test::More::TESTOUT) {
         $fh = \*Test::More::TESTOUT;
     } elsif (-e \*Test::Builder::TESTOUT) {
@@ -53,7 +37,24 @@ my $fh;
 
 my @testitems = (@Support::Files::testitems, @Support::Files::test_files);
 
-# at last, here we actually run the test...
+#add the words to check here:
+my @evilwords = qw(
+    anyways
+    appearence
+    arbitary
+    cancelled
+    critera
+    databasa
+    dependan
+    existance
+    existant
+    paramater
+    refered
+    repsentation
+    suported
+    varsion
+);
+
 my $evilwordsregexp = join('|', @evilwords);
 
 foreach my $file (@testitems) {

t/007util.t

@@ -9,14 +9,18 @@
 #Bugzilla Test 7#
 #####Util.pm#####
 
+use 5.10.1;
+use strict;
+use warnings;
+
 use lib 't';
 use Support::Files;
 use Test::More tests => 17;
 use DateTime;
 
 BEGIN { 
-    use_ok(Bugzilla);
-    use_ok(Bugzilla::Util);
+    use_ok('Bugzilla');
+    use_ok('Bugzilla::Util');
 }
 
 # We need to override user preferences so we can get an expected value when

t/008filter.t

@@ -15,10 +15,11 @@
 
 # Sample exploit code: '>"><script>alert('Oh dear...')</script>
 
+use 5.10.1;
 use strict;
-use lib qw(. lib t);
+use warnings;
 
-use vars qw(%safe);
+use lib qw(. lib t);
 
 use Bugzilla::Constants;
 use Support::Templates;
@@ -30,6 +31,7 @@ use Cwd;
 my $oldrecsep = $/;
 my $topdir = cwd;
 $/ = undef;
+our %safe;
 
 foreach my $path (@Support::Templates::include_paths) {
     $path =~ s|\\|/|g if ON_WINDOWS;  # convert \ to / in path if on windows

t/009bugwords.t

@@ -15,7 +15,9 @@
 # "[% terms.bug %]". This test makes sure the relevant words aren't used
 # bare.
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 

t/010dependencies.t

@@ -10,7 +10,10 @@
 #Bugzilla Test 10#
 ## dependencies ##
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib t);
 
 use Support::Files;

t/011pod.t

@@ -10,7 +10,9 @@
 #Bugzilla Test 11#
 ##POD validation##
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 
@@ -52,7 +54,7 @@ use constant MODULE_WHITELIST => qw(
 # This will handle verbosity for us automatically.
 my $fh;
 {
-    local $^W = 0;  # Don't complain about non-existent filehandles
+    no warnings qw(unopened);  # Don't complain about non-existent filehandles
     if (-e \*Test::More::TESTOUT) {
         $fh = \*Test::More::TESTOUT;
     } elsif (-e \*Test::Builder::TESTOUT) {

t/012throwables.t

@@ -11,7 +11,10 @@
 #Bugzilla Test 12#
 ######Errors######
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib t);
 
 use Bugzilla::Constants;

t/013dbschema.t

@@ -12,7 +12,10 @@
 # Check the Bugzilla database schema to ensure no field names conflict
 # with SQL reserved words.
 
+use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. t lib);
 use Bugzilla;
 use Bugzilla::DB::Schema;

t/Support/Files.pm

@@ -8,15 +8,19 @@
 
 package Support::Files;
 
+use 5.10.1;
+use strict;
+use warnings;
+
 use File::Find;
 
-@additional_files = ();
+our @additional_files = ();
 
-@files = glob('*');
+our @files = glob('*');
 find(sub { push(@files, $File::Find::name) if $_ =~ /\.pm$/;}, 'Bugzilla');
 push(@files, 'extensions/create.pl');
 
-@extensions =
+our @extensions =
     grep { $_ ne 'extensions/create.pl' && ! -e "$_/disabled" }
     glob('extensions/*');
 
@@ -24,7 +28,7 @@ foreach my $extension (@extensions) {
     find(sub { push(@files, $File::Find::name) if $_ =~ /\.pm$/;}, $extension);
 }
 
-@test_files = glob('t/*.t');
+our @test_files = glob('t/*.t');
 
 sub isTestingFile {
     my ($file) = @_;
@@ -40,9 +44,11 @@ sub isTestingFile {
     return undef;
 }
 
-foreach $currentfile (@files) {
+our (@testitems, @module_files);
+
+foreach my $currentfile (@files) {
     if (isTestingFile($currentfile)) {
-        push(@testitems,$currentfile);
+        push(@testitems, $currentfile);
     }
     push(@module_files, $currentfile) if $currentfile =~ /\.pm$/;
 }

t/Support/Systemexec.pm

@@ -6,6 +6,11 @@
 # defined by the Mozilla Public License, v. 2.0.
 
 package Support::Systemexec;
+
+use 5.10.1;
+use strict;
+use warnings;
+
 require Exporter;
 @ISA = qw(Exporter);
 @EXPORT = qw(system exec);

t/Support/Templates.pm

@@ -7,15 +7,15 @@
 
 package Support::Templates;
 
+use 5.10.1;
 use strict;
+use warnings;
 
 use lib 't';
 use parent qw(Exporter);
 @Support::Templates::EXPORT =
     qw(@languages @include_paths @english_default_include_paths
-         %include_path @referenced_files %actual_files $num_actual_files);
-use vars qw(@languages @include_paths @english_default_include_paths
-            %include_path @referenced_files %actual_files $num_actual_files);
+       @referenced_files %actual_files $num_actual_files);
 
 use Bugzilla;
 use Bugzilla::Constants;
@@ -25,18 +25,9 @@ use Support::Files;
 use File::Find;
 use File::Spec;
 
-# The available template languages
-@languages = ();
-
-# The colon separated includepath per language
-%include_path = ();
-
-# All include paths
-@include_paths = ();
-
 # English default include paths
-push @english_default_include_paths,
-    File::Spec->catdir(bz_locations()->{'templatedir'}, 'en', 'default');
+our @english_default_include_paths =
+    (File::Spec->catdir(bz_locations()->{'templatedir'}, 'en', 'default'));
 
 # And the extensions too
 foreach my $extension (@Support::Files::extensions) {
@@ -47,19 +38,19 @@ foreach my $extension (@Support::Files::extensions) {
 }
 
 # Files which are referenced in the cgi files
-@referenced_files = ();
+our @referenced_files = ();
 
 # All files sorted by include_path
-%actual_files = ();
+our %actual_files = ();
 
 # total number of actual_files
-$num_actual_files = 0;
+our $num_actual_files = 0;
 
 # Set the template available languages and include paths
-@languages = @{ Bugzilla->languages };
-@include_paths = @{ template_include_path({ language => Bugzilla->languages }) };
+our @languages = @{ Bugzilla->languages };
+our @include_paths = @{ template_include_path({ language => Bugzilla->languages }) };
 
-my @files;
+our @files;
 
 # Local subroutine used with File::Find
 sub find_templates {

template/en/default/extensions/config.pm.tmpl

@@ -16,6 +16,7 @@ package Bugzilla::Extension::[% name %];
 
 use 5.10.1;
 use strict;
+use warnings;
 
 use constant NAME => '[% name %]';
 

template/en/default/extensions/extension.pm.tmpl

@@ -16,6 +16,8 @@ package Bugzilla::Extension::[% name %];
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Bugzilla::Extension);
 
 # This code for this is in [% path %]/lib/Util.pm

template/en/default/extensions/util.pm.tmpl

@@ -16,6 +16,8 @@ package Bugzilla::Extension::[% name %]::Util;
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use parent qw(Exporter);
 our @EXPORT = qw(
     

testagent.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,6 +12,7 @@
 
 use 5.10.1;
 use strict;
+use warnings;
 
 say "content-type:text/plain\n";
 say "OK " . ($::ENV{MOD_PERL} || "mod_cgi");

testserver.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,6 +12,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

token.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

userprefs.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

votes.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -11,6 +11,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

whine.pl

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -12,6 +12,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

whineatnews.pl

-#!/usr/bin/perl -w
+#!/usr/bin/perl
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -16,6 +16,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;

xmlrpc.cgi

-#!/usr/bin/perl -wT
+#!/usr/bin/perl -T
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -8,6 +8,8 @@
 
 use 5.10.1;
 use strict;
+use warnings;
+
 use lib qw(. lib);
 
 use Bugzilla;