Skip to content

bugzilla
bugzilla
Commit f45ef933 authored by Simon Green's avatar Simon Green Committed by Frédéric Buclin
Browse files
Options

Bug 840824: It is possible to create a new bug with a non active target…

Bug 840824: It is possible to create a new bug with a non active target milestone, version or component r/a=LpSolit
parent aa73e4b5
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 6 deletions
Bugzilla/Bug.pm
View file @ f45ef933
...@@ -1465,8 +1465,7 @@ sub _check_component { ...@@ -1465,8 +1465,7 @@ sub _check_component {
$name || ThrowUserError("require_component"); $name || ThrowUserError("require_component");
my $product = blessed($invocant) ? $invocant->product_obj my $product = blessed($invocant) ? $invocant->product_obj
: $params->{product}; : $params->{product};
my $old_comp = blessed($invocant) ? $invocant->component my $old_comp = blessed($invocant) ? $invocant->component : '';
: $params->{component};
my $object = Bugzilla::Component->check({ product => $product, name => $name }); my $object = Bugzilla::Component->check({ product => $product, name => $name });
if ($object->name ne $old_comp && !$object->is_active) { if ($object->name ne $old_comp && !$object->is_active) {
ThrowUserError('value_inactive', { class => ref($object), value => $name }); ThrowUserError('value_inactive', { class => ref($object), value => $name });
...@@ -1929,8 +1928,7 @@ sub _check_target_milestone { ...@@ -1929,8 +1928,7 @@ sub _check_target_milestone {
my ($invocant, $target, undef, $params) = @_; my ($invocant, $target, undef, $params) = @_;
my $product = blessed($invocant) ? $invocant->product_obj my $product = blessed($invocant) ? $invocant->product_obj
: $params->{product}; : $params->{product};
my $old_target = blessed($invocant) ? $invocant->target_milestone my $old_target = blessed($invocant) ? $invocant->target_milestone : '';
: $params->{target_milestone};
$target = trim($target); $target = trim($target);
$target = $product->default_milestone if !defined $target; $target = $product->default_milestone if !defined $target;
my $object = Bugzilla::Milestone->check( my $object = Bugzilla::Milestone->check(
...@@ -1960,8 +1958,7 @@ sub _check_version { ...@@ -1960,8 +1958,7 @@ sub _check_version {
$version = trim($version); $version = trim($version);
my $product = blessed($invocant) ? $invocant->product_obj my $product = blessed($invocant) ? $invocant->product_obj
: $params->{product}; : $params->{product};
my $old_vers = blessed($invocant) ? $invocant->version my $old_vers = blessed($invocant) ? $invocant->version : '';
: $params->{version};
my $object = Bugzilla::Version->check({ product => $product, name => $version }); my $object = Bugzilla::Version->check({ product => $product, name => $version });
if ($object->name ne $old_vers && !$object->is_active) { if ($object->name ne $old_vers && !$object->is_active) {
ThrowUserError('value_inactive', { class => ref($object), value => $version }); ThrowUserError('value_inactive', { class => ref($object), value => $version });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment