Commit fc65ed17 authored by kiko%async.com.br's avatar kiko%async.com.br

Fix for bug 229800: whineatnews.pl doesn't whine about REOPENED bugs.

Change whine script to look to REOPENED bugs too, and modified text in relevant param to account for this. Patch by joseph@picsel.com (Joseph Heenan). r=kiko, a=myk.
parent bf83c0fa
...@@ -24,6 +24,7 @@ ...@@ -24,6 +24,7 @@
# Jacob Steenhagen <jake@bugzilla.org> # Jacob Steenhagen <jake@bugzilla.org>
# J. Paul Reed <preed@sigkill.com> # J. Paul Reed <preed@sigkill.com>
# Bradley Baetz <bbaetz@student.usyd.edu.au> # Bradley Baetz <bbaetz@student.usyd.edu.au>
# Joseph Heenan <joseph@heenan.me.uk>
# #
# This file defines all the parameters that we have a GUI to edit within # This file defines all the parameters that we have a GUI to edit within
...@@ -557,16 +558,16 @@ Configure bugmail: %urlbase%userprefs.cgi?tab=email ...@@ -557,16 +558,16 @@ Configure bugmail: %urlbase%userprefs.cgi?tab=email
{ {
name => 'whinemail', name => 'whinemail',
desc => 'The email that gets sent to anyone who has a NEW bug that '. desc => 'The email that gets sent to anyone who has a NEW or REOPENED ' .
'hasn\'t been touched for more than <b>whinedays</b>. Within ' . 'bug that hasn\'t been touched for more than <b>whinedays</b>. ' .
'this text, %email% gets replaced by the offender\'s email ' . 'Within this text, %email% gets replaced by the offender\'s ' .
'address. %userid% gets replaced by the offender\'s bugzilla ' . 'email address. %userid% gets replaced by the offender\'s ' .
'login (which, in most installations, is the same as the email ' . 'bugzilla login (which, in most installations, is the same as ' .
' address.) %<i>anythingelse</i>% gets replaced by the definition ' . 'the email address.) %<i>anythingelse</i>% gets replaced by the ' .
'of that parameter (as defined on this page).<p> It is a good ' . 'definition of that parameter (as defined on this page).<p> It ' .
'idea to make sure this message has a valid From: address, so ' . 'is a good idea to make sure this message has a valid From: ' .
'that if the mail bounces, a real person can know that there are ' . 'address, so that if the mail bounces, a real person can know '.
'bugs assigned to an invalid address.', 'that there are bugs assigned to an invalid address.',
type => 'l', type => 'l',
default => 'From: %maintainer% default => 'From: %maintainer%
To: %email% To: %email%
...@@ -578,9 +579,9 @@ You have one or more bugs assigned to you in the Bugzilla ...@@ -578,9 +579,9 @@ You have one or more bugs assigned to you in the Bugzilla
bugsystem (%urlbase%) that require bugsystem (%urlbase%) that require
attention. attention.
All of these bugs are in the NEW state, and have not been touched All of these bugs are in the NEW or REOPENED state, and have not
in %whinedays% days or more. You need to take a look at them, and been touched in %whinedays% days or more. You need to take a look
decide on an initial action. at them, and decide on an initial action.
Generally, this means one of three things: Generally, this means one of three things:
...@@ -593,9 +594,10 @@ Generally, this means one of three things: ...@@ -593,9 +594,10 @@ Generally, this means one of three things:
(3) You decide the bug belongs to you, but you can\'t solve it this moment. (3) You decide the bug belongs to you, but you can\'t solve it this moment.
Just use the "Accept bug" command. Just use the "Accept bug" command.
To get a list of all NEW bugs, you can use this URL (bookmark it if you like!): To get a list of all NEW/REOPENED bugs, you can use this URL (bookmark
it if you like!):
%urlbase%buglist.cgi?bug_status=NEW&assigned_to=%userid% %urlbase%buglist.cgi?bug_status=NEW&bug_status=REOPENED&assigned_to=%userid%
Or, you can use the general query page, at Or, you can use the general query page, at
%urlbase%query.cgi. %urlbase%query.cgi.
......
...@@ -19,12 +19,13 @@ ...@@ -19,12 +19,13 @@
# Rights Reserved. # Rights Reserved.
# #
# Contributor(s): Terry Weissman <terry@mozilla.org> # Contributor(s): Terry Weissman <terry@mozilla.org>
# Joseph Heenan <joseph@heenan.me.uk>
# This is a script suitable for running once a day from a cron job. It # This is a script suitable for running once a day from a cron job. It
# looks at all the bugs, and sends whiny mail to anyone who has a bug # looks at all the bugs, and sends whiny mail to anyone who has a bug
# assigned to them that has status NEW that has not been touched for # assigned to them that has status NEW or REOPENED that has not been
# more than 7 days. # touched for more than 7 days.
use strict; use strict;
...@@ -33,8 +34,9 @@ require "globals.pl"; ...@@ -33,8 +34,9 @@ require "globals.pl";
ConnectToDatabase(); ConnectToDatabase();
SendSQL("select bug_id,short_desc,login_name from bugs,profiles where " . SendSQL("select bug_id,short_desc,login_name from bugs,profiles where " .
"bug_status = 'NEW' and to_days(now()) - to_days(delta_ts) > " . "(bug_status = 'NEW' or bug_status = 'REOPENED') and " .
Param('whinedays') . " and userid=assigned_to order by bug_id"); "to_days(now()) - to_days(delta_ts) > " . Param('whinedays') .
" and userid=assigned_to order by bug_id");
my %bugs; my %bugs;
my %desc; my %desc;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment