Fix for bug 163541: let there be a page title but no primary page header.

2xr=bbaetz

Fix for bug 163541: let there be a page title but no primary page header.
26118155 · myk%mozilla.org · e7e9e5c5 · 26118155
Commit 26118155 authored Aug 20, 2002 by myk%mozilla.org
Show whitespace changes
Inline Side-by-side

Showing with 10 additions and 1 deletion

header.html.tmpl template/en/default/global/header.html.tmpl +10 -1

No files found.
--- a/template/en/default/global/header.html.tmpl
+++ b/template/en/default/global/header.html.tmpl
@@ -40,12 +40,21 @@
 [% END %]

 [% DEFAULT
-  h1 = title
  h2 = ""
  h3 = "" 
  bgcolor = "#ffffff"
  onload = ""
 %]
+
+[%# We should be able to set the default value of the h1 variable
+  # to the value of the title variable using the DEFAULT directive,
+  # but that doesn't work if a caller sets h1 to the empty string
+  # to avoid h1 inheriting the value of title, since DEFAULT
+  # mistakenly treats empty strings as undefined and gives h1 the
+  # value of title anyway.  To get around that problem we explicitly
+  # set h1's default value here only if it is undefined. %]
+[% h1 = title IF !h1.defined %]
+
 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
  <head>