Due to popular request, "bug changed" mail will only report changes in

state on dependent bugs if they move from an 'open' to a 'closed' state, or visa-versa. Also, if there are more than 5 bugs on the list, then we won't even try to generate the details (doing so only generates lots of extra mail that is too hard to parse anyway.)

Due to popular request, "bug changed" mail will only report changes in
4eaaf5f6 · terry%mozilla.org · 0940186c · 4eaaf5f6
Commit 4eaaf5f6 authored Nov 03, 1999 by terry%mozilla.org
Show whitespace changes
Inline Side-by-side

Showing with 17 additions and 8 deletions

processmail processmail +17 -8

No files found.
--- a/processmail
+++ b/processmail
@@ -123,16 +123,24 @@ sub DescDependencies {
        }
        if (@list) {
            my @verbose;
+            my $count = 0;
            foreach my $i (@list) {
-                SendSQL("select bug_status, resolution from bugs where bug_id = $i");
-                my ($bug_status, $resolution) = (FetchSQLData());
-                if ($resolution ne "") {
-                    $resolution = "/$resolution";
-                }
-                push(@verbose, $i . "[$bug_status$resolution]");
-            }
+                SendSQL("select bug_status from bugs where bug_id = $i");
+                my ($bug_status) = (FetchSQLData());
+                my $desc = "[Closed]";
+                if ($bug_status eq "OPEN" || $bug_status eq "NEW" ||
+                    $bug_status eq "REOPENED") {
+                    $desc = "";
+                }
+                push(@verbose, $i . "$desc");
+                $count++;
+            }
+            if ($count > 5) {
+                $result .= "$title: Big list (more than 5) has been omitted\n";
+            } else {
                $result .= "$title: " . join(', ', @verbose) . "\n";
            }
+        }
        my $tmp = $me;
        $me = $target;
        $target = $tmp;
@@ -314,7 +322,8 @@ sub ProcessOneBug {
            my $msg = PerformSubsts(Param("changedmail"), \%substs);

            if (!$regenerate) {
-		# Note: fixaddresses may result in a Cc: only.  This seems harmless.
+                # Note: fixaddresses may result in a Cc: only.  This seems
+                # harmless.
                open(SENDMAIL, "|/usr/lib/sendmail -t") ||
                    die "Can't open sendmail";
                print SENDMAIL $msg;