Skip to content

bugzilla
bugzilla
Commit 70486766 authored by travis%sedsystems.ca's avatar travis%sedsystems.ca
Browse files
Options

Bug 238802 : Input filter for integer sort key gives bad error output

Patch by Frederic Buclin <LpSolit@gmail.com> r=mkanat a=justdave
parent 62383feb
Show whitespace changes
Inline Side-by-side
Showing with 6 additions and 2 deletions
editflagtypes.cgi
View file @ 70486766
...@@ -445,8 +445,10 @@ sub deactivate { ...@@ -445,8 +445,10 @@ sub deactivate {
################################################################################ ################################################################################
sub validateID { sub validateID {
# $::FORM{'id'} is destroyed if detaint_natural fails.
my $flagtype_id = $::FORM{'id'};
detaint_natural($::FORM{'id'}) detaint_natural($::FORM{'id'})
|| ThrowCodeError("flag_type_id_invalid", { id => $::FORM{'id'} }); || ThrowCodeError("flag_type_id_invalid", { id => $flagtype_id });
SendSQL("SELECT 1 FROM flagtypes WHERE id = $::FORM{'id'}"); SendSQL("SELECT 1 FROM flagtypes WHERE id = $::FORM{'id'}");
FetchOneColumn() FetchOneColumn()
...@@ -499,10 +501,12 @@ sub validateComponent { ...@@ -499,10 +501,12 @@ sub validateComponent {
} }
sub validateSortKey { sub validateSortKey {
# $::FORM{'sortkey'} is destroyed if detaint_natural fails.
my $sortkey = $::FORM{'sortkey'};
detaint_natural($::FORM{'sortkey'}) detaint_natural($::FORM{'sortkey'})
&& $::FORM{'sortkey'} < 32768 && $::FORM{'sortkey'} < 32768
|| ThrowUserError("flag_type_sortkey_invalid", || ThrowUserError("flag_type_sortkey_invalid",
{ sortkey => $::FORM{'sortkey'} }); { sortkey => $sortkey });
} }
sub validateTargetType { sub validateTargetType {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment