Commit e8d520f7 authored by zach%zachlipton.com's avatar zach%zachlipton.com

Make this file test for exec calls in addition to system calls that are

one-argument and are therefore insecure. NOT_PART_OF_BUILD, no review needed.
parent 3f57a81f
...@@ -47,11 +47,11 @@ foreach $file (@testitems) { ...@@ -47,11 +47,11 @@ foreach $file (@testitems) {
next if (!$file); # skip null entries next if (!$file); # skip null entries
$command = "$perlapp -c -It/Support -MSystemexec $file 2>&1"; $command = "$perlapp -c -It/Support -MSystemexec $file 2>&1";
$loginfo=`$command`; $loginfo=`$command`;
if ($loginfo =~ /arguments for Systemexec::system/im) { if ($loginfo =~ /arguments for Systemexec::system|exec/im) {
ok(0,"$file DOES NOT use proper system calls"); ok(0,"$file DOES NOT use proper system or exec calls");
if ($verbose) { print STDERR $loginfo; } if ($verbose) { print STDERR $loginfo; }
} else { } else {
ok(1,"$file uses proper system calls"); ok(1,"$file uses proper system and exec calls");
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment