From ea25c5cf646763926a8c6a5dfb04bd356e76905b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Buclin?= <LpSolit@gmail.com>
Date: Wed, 26 Aug 2015 23:37:28 +0200
Subject: [PATCH] Bug 1198659: Custom fields of type INTEGER should accept
negative integers r=gerv a=sgreen
---
Bugzilla/Bug.pm | 2 +-
template/en/default/bug/field.html.tmpl | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 25f74d5f3..34bf95ff7 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -2259,7 +2259,7 @@ sub _check_integer_field {
ThrowUserError("number_not_integer",
{field => $field, num => $orig_value});
}
- elsif ($value > MAX_INT_32) {
+ elsif (abs($value) > MAX_INT_32) {
ThrowUserError("number_too_large",
{field => $field, num => $orig_value, max_num => MAX_INT_32});
}
diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl
index 1eceaf74c..cdf15fbd8 100644
--- a/template/en/default/bug/field.html.tmpl
+++ b/template/en/default/bug/field.html.tmpl
@@ -42,7 +42,10 @@
name="[% field.name FILTER html %]"
value="[% value FILTER html %]" size="40"
maxlength="[% constants.MAX_FREETEXT_LENGTH FILTER none %]"
- [% IF field.type == constants.FIELD_TYPE_INTEGER %] pattern="\d+[% IF dontchange %]|[% dontchange FILTER html %][% END %]" [% END %]
+ [% IF field.type == constants.FIELD_TYPE_INTEGER %]
+ pattern="-?\d+[% IF dontchange %]|[% dontchange FILTER html %][% END %]"
+ title="The value must be a valid positive or negative integer"
+ [% END %]
[% IF field.is_mandatory %]
data-required="true" [% 'aria-required="true" required' UNLESS field_hidden %]
[% END %]>
--
2.24.1