Fix interface of toggle API - #776

7148dea7 · Masayuki Tanaka · b0e78535 · 7148dea7 · 7148dea7 · 7148dea7
Commit 7148dea7 authored Nov 30, 2014 by Masayuki Tanaka
Show whitespace changes
Inline Side-by-side

Showing with 10 additions and 6 deletions

c3.js c3.js +5 -3

c3.min.js c3.min.js +0 -0

api.show.js src/api.show.js +5 -3

No files found.
--- a/c3.js
+++ b/c3.js
@@ -5731,9 +5731,11 @@
        $$.redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withLegend: true});
    };

-    c3_chart_fn.toggle = function (targetId) {
-        var $$ = this.internal;
-        $$.isTargetToShow(targetId) ? this.hide(targetId) : this.show(targetId);
+    c3_chart_fn.toggle = function (targetIds) {
+        var that = this, $$ = this.internal;
+        $$.mapToTargetIds(targetIds).forEach(function (targetId) {
+            $$.isTargetToShow(targetId) ? that.hide(targetId) : that.show(targetId);
+        });
    };

    c3_chart_fn.zoom = function (domain) {

--- a/c3.min.js
+++ b/c3.min.js
--- a/src/api.show.js
+++ b/src/api.show.js
@@ -42,7 +42,9 @@ c3_chart_fn.hide = function (targetIds, options) {
    $$.redraw({withUpdateOrgXDomain: true, withUpdateXDomain: true, withLegend: true});
 };

-c3_chart_fn.toggle = function (targetId) {
-    var $$ = this.internal;
-    $$.isTargetToShow(targetId) ? this.hide(targetId) : this.show(targetId);
+c3_chart_fn.toggle = function (targetIds) {
+    var that = this, $$ = this.internal;
+    $$.mapToTargetIds(targetIds).forEach(function (targetId) {
+        $$.isTargetToShow(targetId) ? that.hide(targetId) : that.show(targetId);
+    });
 };