song: song_file_update() returns bool

Instead of returning 0 or -1, return true on success and false on failure. This seems more natural, and when the C library was designed, there was no "bool" data type.

song: song_file_update() returns bool
02e8c000 · Max Kellermann · 1f9b6148 · 02e8c000 · 02e8c000 · 02e8c000
Commit 02e8c000 authored Oct 08, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

song.c src/song.c +3 -3

song.h src/song.h +1 -1

update.c src/update.c +2 -2

No files found.
--- a/src/song.c
+++ b/src/song.c
@@ -97,7 +97,7 @@ song_free(struct song *song)
 	free(song);
 }

-int
+bool
 song_file_update(struct song *song)
 {
 	struct decoder_plugin *plugin;
@@ -120,9 +120,9 @@ song_file_update(struct song *song)
 		song->tag = plugin->tag_dup(abs_path);

 	if (song->tag == NULL || song->tag->time < 0)
-		return -1;
+		return false;

-	return 0;
+	return true;
 }

 char *

--- a/src/song.h
+++ b/src/song.h
@@ -55,7 +55,7 @@ song_file_load(const char *path, struct directory *parent);
 void
 song_free(struct song *song);

-int
+bool
 song_file_update(struct song *song);

 /*

--- a/src/update.c
+++ b/src/update.c
@@ -232,7 +232,7 @@ updateInDirectory(struct directory *directory, const char *name)
 			return UPDATE_RETURN_UPDATED;
 		} else if (st.st_mtime != song->mtime) {
 			LOG("updating %s\n", name);
-			if (song_file_update(song) < 0)
+			if (!song_file_update(song))
 				delete_song(directory, song);
 			return UPDATE_RETURN_UPDATED;
 		}
@@ -421,7 +421,7 @@ static enum update_return updatePath(const char *utf8path)
 			free(path);
 			if (song->mtime == mtime)
 				return UPDATE_RETURN_NOUPDATE;
-			else if (song_file_update(song) == 0)
+			else if (song_file_update(song))
 				return UPDATE_RETURN_UPDATED;
 			else {
 				delete_song(parentDirectory, song);