client: convert GREETING to a static string

The length of GREETING is known at compile time, don't use strlen().

client: convert GREETING to a static string
0eb1166b · Max Kellermann · 3dc43bb9 · 0eb1166b
Commit 0eb1166b authored 16 years ago by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

client.c src/client.c +2 -2

No files found.
--- a/src/client.c
+++ b/src/client.c
@@ -47,7 +47,7 @@
 #define G_LOG_DOMAIN "client"
 #define LOG_LEVEL_SECURE G_LOG_LEVEL_INFO

-#define GREETING				"OK MPD " PROTOCOL_VERSION "\n"
+static const char GREETING[] = "OK MPD " PROTOCOL_VERSION "\n";

 #define CLIENT_LIST_MODE_BEGIN			"command_list_begin"
 #define CLIENT_LIST_OK_MODE_BEGIN			"command_list_ok_begin"
@@ -202,7 +202,7 @@ static void client_init(struct client *client, int fd)

 	client->permission = getDefaultPermissions();

-	xwrite(fd, GREETING, strlen(GREETING));
+	xwrite(fd, GREETING, sizeof(GREETING) - 1);
 }

 static void free_cmd_list(GSList *list)