Skip to content

M
mpd
Commit 48a84ca2 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

input/rewind: copy the MIME type only once

Reduce heap usage by reducing the number of malloc() / free() calls.
parent c345c5eb
Show whitespace changes
Inline Side-by-side
Showing with 5 additions and 1 deletion
NEWS
View file @ 48a84ca2
ver 0.16.5 (2010/??/??) ver 0.16.5 (2010/??/??)
* pcm_format: fix 32-to-24 bit conversion (the "silence" bug) * pcm_format: fix 32-to-24 bit conversion (the "silence" bug)
* input:
- rewind: reduce heap usage
ver 0.16.4 (2011/09/01) ver 0.16.4 (2011/09/01)
......
src/input/rewind_input_plugin.c
View file @ 48a84ca2
...@@ -83,12 +83,14 @@ copy_attributes(struct input_rewind *r) ...@@ -83,12 +83,14 @@ copy_attributes(struct input_rewind *r)
assert(dest != src); assert(dest != src);
assert(src->mime == NULL || dest->mime != src->mime); assert(src->mime == NULL || dest->mime != src->mime);
bool dest_ready = dest->ready;
dest->ready = src->ready; dest->ready = src->ready;
dest->seekable = src->seekable; dest->seekable = src->seekable;
dest->size = src->size; dest->size = src->size;
dest->offset = src->offset; dest->offset = src->offset;
if (src->mime != NULL) { if (!dest_ready && src->ready) {
g_free(dest->mime); g_free(dest->mime);
dest->mime = g_strdup(src->mime); dest->mime = g_strdup(src->mime);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment