update: make addDirectoryPathToDB() non-recursive

This recursive function is very dangerous because it allocates a large buffer on the stack in every iteration. That may be misused to generate a stack overflow.

update: make addDirectoryPathToDB() non-recursive
4990f04a · Max Kellermann · 8536a979 · 4990f04a
Commit 4990f04a authored Oct 09, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 15 additions and 11 deletions

update.c src/update.c +15 -11

No files found.
--- a/src/update.c
+++ b/src/update.c
@@ -354,21 +354,25 @@ directory_make_child_checked(struct directory *parent, const char *path)
 static struct directory *
 addDirectoryPathToDB(const char *utf8path)
 {
-	char path_max_tmp[MPD_PATH_MAX];
+	struct directory *directory = db_get_root();
-	char *parent;
+	char *duplicated = xstrdup(utf8path);
-	struct directory *parentDirectory;
+	char *slash = duplicated;
-	parent = parent_path(path_max_tmp, utf8path);
+	while (true) {
+		slash = strchr(slash, '/');
+		if (slash != NULL)
+			*slash = 0;
-	if (strlen(parent) == 0)
+		directory = directory_make_child_checked(directory,
-		parentDirectory = db_get_root();
+							 duplicated);
-	else
+		if (directory == NULL || slash == NULL)
-		parentDirectory = addDirectoryPathToDB(parent);
+			break;
-	if (!parentDirectory)
+		*slash++ = '/';
-		return NULL;
+	}
-	return directory_make_child_checked(parentDirectory, utf8path);
+	free(duplicated);
+	return directory;
 }
 static struct directory *