playlist: simplified setPlaylistRandomStatus()

Check the old status before assigning. This saves a temporary variable.

playlist: simplified setPlaylistRandomStatus()
4a510a26 · Max Kellermann · b084bc28 · 4a510a26
Commit 4a510a26 authored Oct 08, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

playlist.c src/playlist.c +2 -3

No files found.
--- a/src/playlist.c
+++ b/src/playlist.c
@@ -1152,11 +1152,11 @@ static void randomizeOrder(int start, int end)

 void setPlaylistRandomStatus(bool status)
 {
-	bool statusWas = playlist.random;
+	if (status == playlist.random)
+		return;

 	playlist.random = status;

-	if (status != statusWas) {
 	if (playlist.random) {
 		/*if(playlist_state==PLAYLIST_STATE_PLAY) {
 		  randomizeOrder(playlist.current+1,
@@ -1170,7 +1170,6 @@ void setPlaylistRandomStatus(bool status)
 		}
 	} else
 		orderPlaylist();
-	}
 }

 void previousSongInPlaylist(void)