don't calculate bytes per sample within the loop

AudioFormat.bits is volatile, and to read it, 3 pointers had to be deferenced. Calculate this value once. This speeds up this function by 5%. git-svn-id: https://svn.musicpd.org/mpd/trunk@7325 09075e82-0dd4-0310-85a5-a0d7c8717e4f

don't calculate bytes per sample within the loop
51e90440 · Max Kellermann · Eric Wong · 96eb0119 · 51e90440
Commit 51e90440 authored Apr 12, 2008 by Max Kellermann Committed by Eric Wong Apr 12, 2008
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

flac_plugin.c src/inputPlugins/flac_plugin.c +2 -1

No files found.
--- a/src/inputPlugins/flac_plugin.c
+++ b/src/inputPlugins/flac_plugin.c
@@ -216,6 +216,7 @@ static FLAC__StreamDecoderWriteStatus flacWrite(const flac_decoder *dec,
 	FLAC__uint16 u16;
 	unsigned char *uc;
 	unsigned int c_samp, c_chan;
+	const unsigned int bytes_per_sample = (data->dc->audioFormat.bits / 8);
 	unsigned int i;
 	float timeChange;
 	FLAC__uint64 newPosition = 0;
@@ -241,7 +242,7 @@ static FLAC__StreamDecoderWriteStatus flacWrite(const flac_decoder *dec,
 		     c_chan++) {
 			u16 = buf[c_chan][c_samp];
 			uc = (unsigned char *)&u16;
-			for (i = 0; i < (unsigned)(data->dc->audioFormat.bits / 8); i++) {
+			for (i = 0; i < bytes_per_sample; i++) {
 				if (data->chunk_length >= FLAC_CHUNK_SIZE) {
 					if (flacSendChunk(data) < 0) {
 						return