audio: don't free uninitialized audio_buffer

free(NULL) isn't explicitly forbidden, but isn't exactly good style. Check the rare case that the audio buffer isn't initialized yet in closeAudioDevice(). In this case, we also don't have to call flushAudioBuffer().

audio: don't free uninitialized audio_buffer
5d0a8ce3 · Max Kellermann · 8d1801c5 · 5d0a8ce3
Commit 5d0a8ce3 authored Sep 10, 2008 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

audio.c src/audio.c +2 -1

No files found.
--- a/src/audio.c
+++ b/src/audio.c
@@ -386,11 +386,12 @@ void closeAudioDevice(void)
 {
 	unsigned int i;

+	if (audio_buffer.buffer != NULL) {
 		flushAudioBuffer();
-
 		free(audio_buffer.buffer);
 		audio_buffer.buffer = NULL;
 		audio_buffer.size = 0;
+	}

 	for (i = 0; i < audioOutputArraySize; ++i) {
 		if (audioDeviceStates[i] == DEVICE_ON)