finally found the segfault, it occurs with random and repeat on,

in queueNextSong() was doing randomizeOrder(0,playlist.length) instead of playlist.length-1 git-svn-id: https://svn.musicpd.org/mpd/trunk@61 09075e82-0dd4-0310-85a5-a0d7c8717e4f

finally found the segfault, it occurs with random and repeat on,
9d4bc4ef · Warren Dukes · 8edc4163 · 9d4bc4ef
Commit 9d4bc4ef authored Feb 25, 2004 by Warren Dukes
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

playlist.c src/playlist.c +2 -2

No files found.
--- a/src/playlist.c
+++ b/src/playlist.c
@@ -395,7 +395,7 @@ void queueNextSongInPlaylist() {
 	}
 	else if(playlist.length && playlist.repeat) {
 		if(playlist.length>1 && playlist.random) {
-			randomizeOrder(0,playlist.length);
+			randomizeOrder(0,playlist.length-1);
 		}
 		playlist.queued = 0;
 		DEBUG("playlist: queue song %i:\"%s\"\n",
@@ -490,7 +490,7 @@ int addSongToPlaylist(FILE * fp, Song * song) {
 		int swap;
 		int start;
 		if(playlist_state==PLAYLIST_STATE_STOP) start = 0;
-		else if(playlist.queued>0) start = playlist.queued+1;
+		else if(playlist.queued>=0) start = playlist.queued+1;
 		else start = playlist.current+1;
 		swap = rand()%(playlist.length-start);
 		swap+=start;