input_curl: don't call input_curl_select() when already at EOF

Calling input_curl_select() after EOF has been reached causes an assertion failure. This can happen if the HTTP response is empty. Check c->eof before calling input_curl_select().

input_curl: don't call input_curl_select() when already at EOF
a7461dc2 · Max Kellermann · f1790fc8 · a7461dc2
Commit a7461dc2 authored Jan 15, 2009 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

input_curl.c src/input_curl.c +3 -1

No files found.
--- a/src/input_curl.c
+++ b/src/input_curl.c
@@ -225,6 +225,8 @@ input_curl_select(struct input_curl *c)
 		.tv_usec = 0,
 	};

+	assert(!c->eof);
+
 	FD_ZERO(&rfds);
 	FD_ZERO(&wfds);
 	FD_ZERO(&efds);
@@ -478,7 +480,7 @@ input_curl_buffer(struct input_stream *is)

 	c->buffered = false;

-	if (!is->ready)
+	if (!is->ready && !c->eof)
 		/* not ready yet means the caller is waiting in a busy
 		   loop; relax that by calling select() on the
 		   socket */