alsa_mixer: call snd_config_update_free_global() in finish()

snd_config_update_free_global() frees cached ALSA configuration. This keeps valgrind a little bit more quiet. This patch moves the call from the open() method into the finish() method, which seems more natural: it allows the use of the config cache, and improves the cleanup phase.

alsa_mixer: call snd_config_update_free_global() in finish()
eb059a78 · Max Kellermann · 63710ff5 · eb059a78
Commit eb059a78 authored Apr 21, 2009 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

alsa_mixer.c src/mixer/alsa_mixer.c +3 -1

No files found.
--- a/src/mixer/alsa_mixer.c
+++ b/src/mixer/alsa_mixer.c
@@ -61,6 +61,9 @@ alsa_mixer_finish(struct mixer *data)
 	struct alsa_mixer *am = (struct alsa_mixer *)data;

 	g_free(am);
+
+	/* free libasound's config cache */
+	snd_config_update_free_global();
 }

 static void
@@ -83,7 +86,6 @@ alsa_mixer_open(struct mixer *data)
 	am->volume_set = -1;

 	err = snd_mixer_open(&am->handle, 0);
-	snd_config_update_free_global();
 	if (err < 0) {
 		g_warning("problems opening alsa mixer: %s\n", snd_strerror(err));
 		return false;