encoder/vorbis: remove vorbis_info_clear() calls from error code paths

The destructor will call this in any case.

encoder/vorbis: remove vorbis_info_clear() calls from error code paths
efcda95d · Max Kellermann · 80d2028b · efcda95d
Commit efcda95d authored 8 years ago by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

VorbisEncoderPlugin.cxx src/encoder/plugins/VorbisEncoderPlugin.cxx +0 -2

No files found.
--- a/src/encoder/plugins/VorbisEncoderPlugin.cxx
+++ b/src/encoder/plugins/VorbisEncoderPlugin.cxx
@@ -163,7 +163,6 @@ VorbisEncoder::Open(float quality, int bitrate, AudioFormat &_audio_format,
 						quality * 0.1)) {
 			error.Set(vorbis_encoder_domain,
 				  "error initializing vorbis vbr");
-			vorbis_info_clear(&vi);
 			return false;
 		}
 	} else {
@@ -175,7 +174,6 @@ VorbisEncoder::Open(float quality, int bitrate, AudioFormat &_audio_format,
 					    bitrate * 1000, -1.0)) {
 			error.Set(vorbis_encoder_domain,
 				  "error initializing vorbis encoder");
-			vorbis_info_clear(&vi);
 			return false;
 		}
 	}