Skip to content

M
mpd
Commit ff69f122 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

shout: use strcmp() instead of strncasecmp()

Case insensitivity isn't helpful, and comparing only the first 3 bytes of a configured value may encourage users to supply wrong or misleading values.
parent ffed2fdc
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
src/audioOutputs/audioOutput_shout.c
View file @ ff69f122
......@@ -191,9 +191,9 @@ static void *my_shout_init_driver(struct audio_output *audio_output,
block_param = getBlockParam(param, "encoding");
if (block_param) {
if (0 == strncasecmp(block_param->value, "mp3", 3))
if (0 == strcmp(block_param->value, "mp3"))
encoding = block_param->value;
else if (0 == strncasecmp(block_param->value, "ogg", 3))
else if (0 == strcmp(block_param->value, "ogg"))
encoding = block_param->value;
else
FATAL("shout encoding \"%s\" is not \"ogg\" or "
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment