input/buffered: implement seeking to end of file

Previously, a seek to the end of the file would cause an assertion failure in SparseMap::Check() because the given offset was invalid. Closes #453

input/buffered: implement seeking to end of file
ffc36d52 · Max Kellermann · 0126276e · ffc36d52 · ffc36d52
Commit ffc36d52 authored Jan 22, 2019 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

NEWS NEWS +2 -0

BufferedInputStream.cxx src/input/BufferedInputStream.cxx +5 -0

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.21.5 (not yet released)
 * protocol
  - fix deadlock in "albumart" command
+* input
+  - buffer: fix crash bug when playing remote WAV file
 * tags
  - ape: map "Album Artist"
 * output

--- a/src/input/BufferedInputStream.cxx
+++ b/src/input/BufferedInputStream.cxx
@@ -66,6 +66,11 @@ BufferedInputStream::Check()
 void
 BufferedInputStream::Seek(offset_type new_offset)
 {
+	if (new_offset >= size) {
+		offset = size;
+		return;
+	}
 	auto r = buffer.Read(new_offset);
 	if (r.HasData()) {
 		/* nice, we already have some data at the desired