Address PR comments

stable/kapacitor/README.md

@@ -44,25 +44,25 @@ The command removes all the Kubernetes components associated with the chart and
 ## Configuration
 
 The following tables lists the configurable parameters of the Kapacitor chart and 
-their default values.
+the meaning of the field. The default values are listed in `values.yaml`.
 
 ```yaml
-image.repository: "kapacitor"
-image.tag: "1.1.0"
-image.pullPolicy: "IfNotPresent"
-service.type: NodePort
-persistence.enabled: false
-persistence.storageClass: generic
-persistence.accessMode: ReadWriteOnce
-persistence.size: 8Gi
-resources.requests.memory: 256Mi
-resources.requests.cpu: 0.1
-resources.limits.memory: 2Gi
-resources.limits.cpu: 2
+image.repository: Docker image repo to use
+image.tag: Docker image tag to use
+image.pullPolicy: Image pull policy (IfNotPresent, Always)
+service.type: Type of service (NodePort, LoadBalancer)
+persistence.enabled: Set to true to enable automatic provisioning of a persistent disk
+persistence.storageClass: Sorage class for the persistent disk
+persistence.accessMode: Access mode for the persistent disk
+persistence.size: Size of the persistent disk in Gi or Mi
+resources.requests.memory: Min amount of memory the pod requires
+resources.requests.cpu: Min amount of cpu required by the pod
+resources.limits.memory: Max amount of memory the pod requires
+resources.limits.cpu: Max amount of cpu required by the pod
 
 # This is the location where kapacitor will look for an Influxdb
 # instance to create a subscription on.
-InfluxURL: http://influxdb-influxdb.tick:8086
+influxURL: An InfluxDB url with port. 
 ```
 
 The [full image documentation](https://hub.docker.com/_/kapacitor/) contains more information about running Kapacitor in docker.
@@ -71,7 +71,7 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
 
 ```bash
 $ helm install --name my-release \
-  --set InfluxURL=http://myinflux.mytld:8086,persistence.enabled=true \
+  --set influxURL=http://myinflux.mytld:8086,persistence.enabled=true \
     stable/kapacitor
 ```
 

stable/kapacitor/templates/NOTES.txt

@@ -10,13 +10,13 @@ You can also connect to the container running Kapacitor. To open a shell session
 
 - kubectl exec -i -t --namespace {{ .Release.Namespace }} $(kubectl get pods --namespace {{ .Release.Namespace }} -l app={{ template "fullname" . }} -o jsonpath='{.items[0].metadata.name}') /bin/sh
 
-To trail the logs for the Kapacitor pod run the following:
+To tail the logs for the Kapacitor pod run the following:
 
 - kubectl logs -f --namespace {{ .Release.Namespace }} $(kubectl get pods --namespace {{ .Release.Namespace }} -l app={{ template "fullname" . }} -o jsonpath='{ .items[0].metadata.name }')
 
 {{- if eq .Values.service.type "LoadBalancer" }}
 
-To watch for the LoadBalancer IP run the following
+To watch for the LoadBalancer IP or Hostname to populate run the following:
 
 - kubectl get svc -w --namespace {{ .Release.Namespace }} -l app={{ template "fullname" . }}
 {{- end }}
\ No newline at end of file

stable/kapacitor/templates/deployment.yaml

@@ -22,7 +22,7 @@ spec:
         - name: KAPACITOR_HOSTNAME
           value: {{ template "fullname" . }}.{{ .Release.Namespace }}
         - name: KAPACITOR_INFLUXDB_0_URLS_0
-          value: {{ .Values.InfluxURL }}
+          value: {{ .Values.influxURL }}
         ports:
         - containerPort: 9092
         volumeMounts:

stable/kapacitor/templates/service.yaml

@@ -12,5 +12,6 @@ spec:
   ports:
   - port: 9092
     targetPort: 9092
+    name: api
   selector:
     app: {{ template "fullname" . }}

stable/kapacitor/values.yaml

@@ -6,13 +6,15 @@ image:
   tag: "1.1.0"
   pullPolicy: "IfNotPresent"
 
-## Specify a service type
-## NodePort is default
+## Specify a service type, defaults to NodePort
 ## ref: http://kubernetes.io/docs/user-guide/services/
+##
 service:
   type: NodePort
 
 ## Persist data to a persitent volume
+## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+##
 persistence:
   enabled: false
   storageClass: generic
@@ -30,5 +32,7 @@ resources:
     memory: 2Gi
     cpu: 2
     
-# Set url for kapacitor to point to 
-InfluxURL: http://influxdb-influxdb.tick:8086
+## Set the URL of InfluxDB instance to create subscription on
+## ref: https://docs.influxdata.com/kapacitor/v1.1/introduction/getting_started/
+##
+influxURL: http://influxdb-influxdb.tick:8086