fix: links to subtitles with special characters (#1949)

This issue is related to #1006 . The $vuetify.goTo() function expects a UTF-8 ev.target.hash . However, the markdown CRM URIencodes the ev.target.hash (this is great for browser compatibility, not so much for Vuetify) Adding decodeURIComponent() to ev.target.hash fixes compatibility with Vuetify. This fixes GitHub issue #1873

fix: links to subtitles with special characters (#1949)
006dae12 · IndieRodo · GitHub · 5c07ce0a · 006dae12
Unverified Commit 006dae12 authored May 30, 2020 by IndieRodo Committed by GitHub May 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

page.vue client/themes/default/components/page.vue +2 -1

No files found.
--- a/client/themes/default/components/page.vue
+++ b/client/themes/default/components/page.vue
@@ -530,12 +530,13 @@ export default {
      }
    }

+    // -> Handle anchor links within the page contents
    this.$nextTick(() => {
      this.$refs.container.querySelectorAll(`a[href^="#"], a[href^="${window.location.href.replace(window.location.hash, '')}#"]`).forEach(el => {
        el.onclick = ev => {
          ev.preventDefault()
          ev.stopPropagation()
-          this.$vuetify.goTo(ev.target.hash, this.scrollOpts)
+          this.$vuetify.goTo(decodeURIComponent(ev.target.hash), this.scrollOpts)
        }
      })
    })