Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wiki-js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
wiki-js
Commits
65f71d8e
Commit
65f71d8e
authored
Jun 05, 2020
by
NGPixel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: strip starting slash from path during page create
parent
deacd80c
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
2 deletions
+12
-2
pages.js
server/models/pages.js
+12
-2
No files found.
server/models/pages.js
View file @
65f71d8e
...
...
@@ -214,7 +214,7 @@ module.exports = class Page extends Model {
*/
static
async
createPage
(
opts
)
{
// -> Validate path
if
(
opts
.
path
.
indexOf
(
'.'
)
>=
0
||
opts
.
path
.
indexOf
(
' '
)
>=
0
||
opts
.
path
.
indexOf
(
'
\
\'
) >= 0) {
if
(
opts
.
path
.
indexOf
(
'.'
)
>=
0
||
opts
.
path
.
indexOf
(
' '
)
>=
0
||
opts
.
path
.
indexOf
(
'
\
\'
) >= 0
|| opts.path.indexOf('
//') >= 0
) {
throw
new
WIKI
.
Error
.
PageIllegalPath
()
}
...
...
@@ -223,6 +223,11 @@ module.exports = class Page extends Model {
opts
.
path
=
opts
.
path
.
slice
(
0
,
-
1
)
}
// -> Remove starting slash
if
(
opts
.
path
.
startsWith
(
'/'
))
{
opts
.
path
=
opts
.
path
.
slice
(
1
)
}
// -> Check for page access
if
(
!
WIKI
.
auth
.
checkAccess
(
opts
.
user
,
[
'write:pages'
],
{
locale
:
opts
.
locale
,
...
...
@@ -404,7 +409,7 @@ module.exports = class Page extends Model {
}
// -> Validate path
if (opts.destinationPath.indexOf('
.
') >= 0 || opts.destinationPath.indexOf('
') >= 0 || opts.destinationPath.indexOf('
\\
') >= 0) {
if
(
opts
.
destinationPath
.
indexOf
(
'.'
)
>=
0
||
opts
.
destinationPath
.
indexOf
(
' '
)
>=
0
||
opts
.
destinationPath
.
indexOf
(
'
\
\'
) >= 0
|| opts.destinationPath.indexOf('
//') >= 0
) {
throw
new
WIKI
.
Error
.
PageIllegalPath
()
}
...
...
@@ -413,6 +418,11 @@ module.exports = class Page extends Model {
opts
.
destinationPath
=
opts
.
destinationPath
.
slice
(
0
,
-
1
)
}
// -> Remove starting slash
if
(
opts
.
destinationPath
.
startsWith
(
'/'
))
{
opts
.
destinationPath
=
opts
.
destinationPath
.
slice
(
1
)
}
// -> Check for source page access
if
(
!
WIKI
.
auth
.
checkAccess
(
opts
.
user
,
[
'manage:pages'
],
{
locale
:
page
.
localeCode
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment