fix: use global replace for analytics header templates (#1134)

Support replacing multiple instances of the same template variable in analytics templates

fix: use global replace for analytics header templates (#1134)
7db814c7 · Phil Cullen · Nicolas Giard · ab8391c0 · 7db814c7
Commit 7db814c7 authored Oct 23, 2019 by Phil Cullen Committed by Nicolas Giard Oct 23, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

analytics.js server/models/analytics.js +1 -1

No files found.
--- a/server/models/analytics.js
+++ b/server/models/analytics.js
@@ -117,7 +117,7 @@ module.exports = class Analytics extends Model {
        code.bodyEnd = _.defaultTo(code.bodyEnd, '')

        _.forOwn(provider.config, (value, key) => {
-          code.head = _.replace(code.head, `{{${key}}}`, value)
+          code.head = _.replace(code.head, new RegExp(`{{${key}}}`, 'g'), value)
          code.bodyStart = _.replace(code.bodyStart, `{{${key}}}`, value)
          code.bodyEnd = _.replace(code.bodyEnd, `{{${key}}}`, value)
        })