Unverified Commit de19d379 authored by Jeffrey Forman's avatar Jeffrey Forman Committed by GitHub

fix: helm - image tag and imagePullPolicy to correctly inherit from values (#2472)

* fix image tag and imagePullPolicy to correcy inherit from values, with sane defaults (ifNotPresent and latest) * fix default service ports for http and https in service.yaml Co-authored-by: 's avatarJeffrey Forman <jforman@gmail.com> ***NO_CI***
parent 5a9df24f
......@@ -25,8 +25,8 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
image: "{{ .Values.image.repository }}:{{ default "latest" .Values.image.tag }}"
imagePullPolicy: {{ default "IfNotPresent" .Values.image.imagePullPolicy }}
env:
- name: DB_TYPE
value: postgres
......
......@@ -12,11 +12,11 @@ metadata:
spec:
type: {{.Values.service.type}}
ports:
- port: {{.Values.service.port}}
- port: {{ default "80" .Values.service.port}}
targetPort: http
protocol: TCP
name: http
- port: {{.Values.service.httpsPort}}
- port: {{ default "443" .Values.service.httpsPort}}
targetPort: http
protocol: TCP
name: https
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment