shell32: Fix a leak on error path (Coverity).

Signed-off-by: Sven Baars <sbaars@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

shell32: Fix a leak on error path (Coverity).
2dac8052 · Sven Baars · Alexandre Julliard · 94b2db85 · 2dac8052
Commit 2dac8052 authored Oct 04, 2020 by Sven Baars Committed by Alexandre Julliard Oct 05, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

shfldr_unixfs.c dlls/shell32/shfldr_unixfs.c +4 -1

No files found.
--- a/dlls/shell32/shfldr_unixfs.c
+++ b/dlls/shell32/shfldr_unixfs.c
@@ -1251,7 +1251,10 @@ static HRESULT WINAPI ShellFolder2_GetDisplayNameOf(IShellFolder2* iface,
                LPWSTR pwszDosFileName = wine_get_dos_file_name(This->m_pszPath);
                if (!pwszDosFileName) return HRESULT_FROM_WIN32(GetLastError());
                lpName->u.pOleStr = SHAlloc((lstrlenW(pwszDosFileName) + 1) * sizeof(WCHAR));
-                if (!lpName->u.pOleStr) return HRESULT_FROM_WIN32(GetLastError());
+                if (!lpName->u.pOleStr) {
+                    heap_free(pwszDosFileName);
+                    return HRESULT_FROM_WIN32(GetLastError());
+                }
                lstrcpyW(lpName->u.pOleStr, pwszDosFileName);
                PathRemoveBackslashW(lpName->u.pOleStr);
                heap_free(pwszDosFileName);