quartz: Return E_POINTER from IVideoWindow::get_Visible() if "visible" is NULL.

Signed-off-by: Pengpeng Dong <dongpengpeng@uniontech.com> Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz: Return E_POINTER from IVideoWindow::get_Visible() if "visible" is NULL.
4765c5ff · Pengpeng Dong · Alexandre Julliard · f92f363b · 4765c5ff · 4765c5ff
Commit 4765c5ff authored Sep 09, 2020 by Pengpeng Dong Committed by Alexandre Julliard Sep 09, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

videorenderer.c dlls/quartz/tests/videorenderer.c +3 -0

window.c dlls/quartz/window.c +3 -0

No files found.
--- a/dlls/quartz/tests/videorenderer.c
+++ b/dlls/quartz/tests/videorenderer.c
@@ -2257,6 +2257,9 @@ static void test_video_window(void)
    hr = IBaseFilter_QueryInterface(filter, &IID_IVideoWindow, (void **)&window);
    ok(hr == S_OK, "Got hr %#x.\n", hr);

+    hr = IVideoWindow_get_Visible(window, NULL);
+    ok(hr == E_POINTER, "Got hr %#x.\n", hr);
+
    hr = IVideoWindow_get_Caption(window, &caption);
    todo_wine ok(hr == VFW_E_NOT_CONNECTED, "Got hr %#x.\n", hr);


--- a/dlls/quartz/window.c
+++ b/dlls/quartz/window.c
@@ -334,6 +334,9 @@ HRESULT WINAPI BaseControlWindowImpl_get_Visible(IVideoWindow *iface, LONG *visi

    TRACE("window %p, visible %p.\n", window, visible);

+    if (!visible)
+        return E_POINTER;
+
    *visible = IsWindowVisible(window->hwnd) ? OATRUE : OAFALSE;
    return S_OK;
 }