Suggested changes made

Good catch. <code>init()</code> is now only defining the <code>text</code> tag in the main chart. I've moved the setting of the <code>x</code> and <code>y</code> into <code>redraw()</code> along with the label text. <code>x</code> and <code>y</code> are using <code>width</code> and <code>height</code> instead of calculating <code>(getCurrentWidth() - margin.left - margin.right)</code> as before. Indentation corrected as well, so Travis CI shouldn't error out on that either.

Suggested changes made
b8a466db · Brandon Bernal · 8d64915c · b8a466db
Commit b8a466db authored May 28, 2014 by Brandon Bernal
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 7 deletions

c3.js c3.js +10 -7

No files found.
--- a/c3.js
+++ b/c3.js
@@ -2808,15 +2808,10 @@
            updateLegend(mapToIds(c3.data.targets), {withTransform: false, withTransitionForTransform: false});

            /*-- Main Region --*/
-            if (c3.data.targets.length === 0) {
-              main.append("text")
+            main.append("text")
                .attr("class", CLASS.text + ' ' + CLASS.empty)
-                .attr("x", (getCurrentWidth() - margin.left - margin.right) / 2)
-                .attr("y", (getCurrentHeight() - margin.top - margin.bottom) / 2)
                .attr("text-anchor", "middle") // horizontal centering of text at x position in all browsers.
-                .attr("dominant-baseline", "middle") // vertical centering of text at y position in all browsers, except IE.
-                .text(__data_empty_label_text);
-            }
+                .attr("dominant-baseline", "middle"); // vertical centering of text at y position in all browsers, except IE.

            // Grids
            grid = main.append('g')
@@ -3477,6 +3472,14 @@
            // xgrid focus
            updateXgridFocus();

+            // Data empty label positioning and text.
+            if (c3.data.targets.length === 0) {
+                main.select("text." + CLASS.text + '.' + CLASS.empty)
+                    .attr("x", width / 2)
+                    .attr("y", height / 2)
+                    .text(__data_empty_label_text);
+            }
+
            // grid
            main.select('line.' + CLASS.xgridFocus).style("visibility", "hidden");
            if (__grid_x_show) {