Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
c3-closed
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
charts
c3-closed
Commits
c5fab489
Commit
c5fab489
authored
Nov 15, 2014
by
Masayuki Tanaka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Accept d3.selection object for bindto - #715
parent
1d6b4302
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
2 deletions
+16
-2
c3.js
c3.js
+1
-1
c3.min.js
c3.min.js
+0
-0
core-spec.js
spec/core-spec.js
+14
-0
core.js
src/core.js
+1
-1
No files found.
c3.js
View file @
c5fab489
...
...
@@ -151,7 +151,7 @@
if
(
$$
.
initBrush
)
{
$$
.
initBrush
();
}
if
(
$$
.
initZoom
)
{
$$
.
initZoom
();
}
$$
.
selectChart
=
d3
.
select
(
config
.
bindto
);
$$
.
selectChart
=
typeof
config
.
bindto
.
node
===
'function'
?
config
.
bindto
:
d3
.
select
(
config
.
bindto
);
if
(
$$
.
selectChart
.
empty
())
{
$$
.
selectChart
=
d3
.
select
(
document
.
createElement
(
'div'
)).
style
(
'opacity'
,
0
);
$$
.
observeInserted
(
$$
.
selectChart
);
...
...
c3.min.js
View file @
c5fab489
This source diff could not be displayed because it is too large. You can
view the blob
instead.
spec/core-spec.js
View file @
c5fab489
...
...
@@ -56,4 +56,18 @@ describe('c3 chart', function () {
});
describe
(
'bindto'
,
function
()
{
it
(
'should accept d3.selection object'
,
function
()
{
args
.
bindto
=
d3
.
select
(
'#chart'
);
expect
(
true
).
toBeTruthy
();
});
it
(
'should be created'
,
function
()
{
var
svg
=
d3
.
select
(
'#chart svg'
);
expect
(
svg
).
not
.
toBeNull
();
});
});
});
src/core.js
View file @
c5fab489
...
...
@@ -146,7 +146,7 @@ c3_chart_internal_fn.initWithData = function (data) {
if
(
$$
.
initBrush
)
{
$$
.
initBrush
();
}
if
(
$$
.
initZoom
)
{
$$
.
initZoom
();
}
$$
.
selectChart
=
d3
.
select
(
config
.
bindto
);
$$
.
selectChart
=
typeof
config
.
bindto
.
node
===
'function'
?
config
.
bindto
:
d3
.
select
(
config
.
bindto
);
if
(
$$
.
selectChart
.
empty
())
{
$$
.
selectChart
=
d3
.
select
(
document
.
createElement
(
'div'
)).
style
(
'opacity'
,
0
);
$$
.
observeInserted
(
$$
.
selectChart
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment