Only do multi-fadvise if previous call was successful

Reported-by: Reda Noushi <reda@logzilla.pro> > one remark: what should nocache do if a non-zero value is returned by posix_fadvise()? > 1. is it okay to continue executing it and returning the last value? > 2. or stop execution and return the last non-zero value of fadv()?

Only do multi-fadvise if previous call was successful
07728270 · Julius Plenz · 097ecc4b · 07728270
Commit 07728270 authored Apr 29, 2013 by Julius Plenz
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

fcntl_helpers.c fcntl_helpers.c +1 -1

No files found.
--- a/fcntl_helpers.c
+++ b/fcntl_helpers.c
@@ -8,7 +8,7 @@
 int fadv_dontneed(int fd, off_t offset, off_t len, int n)
 {
        int i, ret;
-        for(i = 0; i < n; i++)
+        for(i = 0, ret = 0; i < n && ret == 0; i++)
            ret = posix_fadvise(fd, offset, len, POSIX_FADV_DONTNEED);
        return ret;
 }