sync_if_writable() now correctly checks O_ACCMODE

43c71e1a · Julius Plenz · e15e0a9f · 43c71e1a
Commit 43c71e1a authored Feb 04, 2012 by Julius Plenz
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

fcntl_helpers.c fcntl_helpers.c +2 -2

No files found.
--- a/fcntl_helpers.c
+++ b/fcntl_helpers.c
@@ -12,8 +12,8 @@ int fadv_dontneed(int fd, off_t offset, off_t len)
 void sync_if_writable(int fd)
 {
    int r;
-    if((r = fcntl(fd, F_GETFL, 0)) == -1)
+    if((r = fcntl(fd, F_GETFL)) == -1)
        return;
-    if(!(r & O_RDONLY))
+    if((r & O_ACCMODE) != O_RDONLY)
        fdatasync(fd);
 }