• Ulrich Sibiller's avatar
    ProcGetPointerMapping uses rep.nElts before it is initialized · 389e3a44
    Ulrich Sibiller authored
    Backport of this xorg upstream commit (with omitting the mentioned
    d792ac125a0462a04a930af543cbc732f8cdab7d).
    
      commit 34cf559bcf99dad550527b5ff53f247f0e8e73ee
      Author: Keith Packard <keithp@keithp.com>
      Date:   Tue Jul 10 15:58:48 2012 -0700
    
        ProcGetPointerMapping uses rep.nElts before it is initialized
    
        In:
    
                commit d792ac125a0462a04a930af543cbc732f8cdab7d
                Author: Alan Coopersmith <alan.coopersmith@oracle.com>
                Date:   Mon Jul 9 19:12:43 2012 -0700
    
                    Use C99 designated initializers in dix Replies
    
        the initializer for the .length element of the xGetPointerMappingReply
        structure uses the value of rep.nElts, but that won't be set until
        after this initializer runs, so we get garbage in the length element
        and clients using it will generally wedge.
    
        Easy to verify:
    
                $ xmodmap -pp
    
        Fixed by creating a local nElts variable and using that.
    Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
    Reviewed-by: 's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    Backported-to-NX-by: 's avatarUlrich Sibiller <uli42@gmx.de>
    389e3a44
devices.c 41.7 KB