Reject negative string counts in copy_string_list

Silences parfait warning of a potential memory leak: Memory leak of pointer 'dst' allocated with malloc(length) at line 160 of FSWrap.c in function 'copy_string_list'. 'dst' allocated at line 145 with malloc(length). dst leaks when count <= 0 at line 154. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>

Reject negative string counts in copy_string_list
30d4454e · Alan Coopersmith · Ulrich Sibiller · 0f089824 · 30d4454e
Commit 30d4454e authored Nov 29, 2011 by Alan Coopersmith Committed by Ulrich Sibiller Oct 19, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

FSWrap.c nx-X11/lib/X11/FSWrap.c +1 -1

No files found.
--- a/nx-X11/lib/X11/FSWrap.c
+++ b/nx-X11/lib/X11/FSWrap.c
@@ -130,7 +130,7 @@ copy_string_list(
    char **string_list_ret, **list_src, **list_dst, *dst;
    int length, count;

-    if (string_list == NULL || list_count == 0)
+    if (string_list == NULL || list_count <= 0)
 	return (char **) NULL;

    string_list_ret = (char **) Xmalloc(sizeof(char *) * list_count);