Commit 3f9ebf33 authored by walter harms's avatar walter harms Committed by Ulrich Sibiller

no need to check args for Xfree()

simplify code Signed-off-by: 's avatarwalter harms <wharms@bfs.de>
parent 897b8b28
...@@ -1027,10 +1027,8 @@ freeByteM( ...@@ -1027,10 +1027,8 @@ freeByteM(
} }
blst = codeset->byteM; blst = codeset->byteM;
for (i = 0; i < codeset->length; i++) { for (i = 0; i < codeset->length; i++) {
if (blst[i].byteinfo) {
Xfree(blst[i].byteinfo); Xfree(blst[i].byteinfo);
blst[i].byteinfo = NULL; blst[i].byteinfo = NULL;
}
} }
Xfree(codeset->byteM); Xfree(codeset->byteM);
codeset->byteM = NULL; codeset->byteM = NULL;
...@@ -1044,20 +1042,18 @@ freeConversion( ...@@ -1044,20 +1042,18 @@ freeConversion(
if (codeset->mbconv) { if (codeset->mbconv) {
mbconv = codeset->mbconv; mbconv = codeset->mbconv;
/* ... */ /* ... */
if (mbconv->convlist) { Xfree(mbconv->convlist);
Xfree(mbconv->convlist); mbconv->convlist = NULL;
mbconv->convlist = NULL;
}
Xfree(mbconv); Xfree(mbconv);
codeset->mbconv = NULL; codeset->mbconv = NULL;
} }
if (codeset->ctconv) { if (codeset->ctconv) {
ctconv = codeset->ctconv; ctconv = codeset->ctconv;
/* ... */ /* ... */
if (ctconv->convlist) { Xfree(ctconv->convlist);
Xfree(ctconv->convlist); ctconv->convlist = NULL;
ctconv->convlist = NULL;
}
Xfree(ctconv); Xfree(ctconv);
codeset->ctconv = NULL; codeset->ctconv = NULL;
} }
...@@ -1072,14 +1068,12 @@ freeExtdSegment( ...@@ -1072,14 +1068,12 @@ freeExtdSegment(
return; return;
} }
ctextseg = codeset->ctextseg; ctextseg = codeset->ctextseg;
if (ctextseg->name) { Xfree(ctextseg->name);
Xfree(ctextseg->name); ctextseg->name = NULL;
ctextseg->name = NULL;
} Xfree(ctextseg->area);
if (ctextseg->area) { ctextseg->area = NULL;
Xfree(ctextseg->area);
ctextseg->area = NULL;
}
Xfree(codeset->ctextseg); Xfree(codeset->ctextseg);
codeset->ctextseg = NULL; codeset->ctextseg = NULL;
} }
...@@ -1093,10 +1087,10 @@ freeParseInfo( ...@@ -1093,10 +1087,10 @@ freeParseInfo(
return; return;
} }
parse_info = codeset->parse_info; parse_info = codeset->parse_info;
if (parse_info->encoding) {
Xfree(parse_info->encoding); Xfree(parse_info->encoding);
parse_info->encoding = NULL; parse_info->encoding = NULL;
}
Xfree(codeset->parse_info); Xfree(codeset->parse_info);
codeset->parse_info = NULL; codeset->parse_info = NULL;
} }
...@@ -1115,10 +1109,10 @@ destroy_CodeSetList( ...@@ -1115,10 +1109,10 @@ destroy_CodeSetList(
freeConversion(codeset[i]); freeConversion(codeset[i]);
freeExtdSegment(codeset[i]); freeExtdSegment(codeset[i]);
freeParseInfo(codeset[i]); freeParseInfo(codeset[i]);
if (codeset[i]->charset_list) {
Xfree(codeset[i]->charset_list); Xfree(codeset[i]->charset_list);
codeset[i]->charset_list = NULL; codeset[i]->charset_list = NULL;
}
Xfree(codeset[i]); codeset[i]=NULL; Xfree(codeset[i]); codeset[i]=NULL;
} }
Xfree(codeset); gen->codeset_list = NULL; Xfree(codeset); gen->codeset_list = NULL;
...@@ -1130,21 +1124,20 @@ destroy_SegConv( ...@@ -1130,21 +1124,20 @@ destroy_SegConv(
{ {
SegConv seg = gen->segment_conv; SegConv seg = gen->segment_conv;
int i; int i;
if (gen->segment_conv_num == 0) { if (gen->segment_conv_num == 0) {
return; return;
} }
for (i=0;i<gen->segment_conv_num;i++) { for (i=0;i<gen->segment_conv_num;i++) {
if (seg[i].source_encoding) {
Xfree(seg[i].source_encoding); Xfree(seg[i].source_encoding);
seg[i].source_encoding = NULL; seg[i].source_encoding = NULL;
}
if (seg[i].destination_encoding) {
Xfree(seg[i].destination_encoding); Xfree(seg[i].destination_encoding);
seg[i].destination_encoding = NULL; seg[i].destination_encoding = NULL;
}
if (seg[i].conv) { Xfree(seg[i].conv);
Xfree(seg[i].conv); seg[i].conv = NULL; seg[i].conv = NULL;
}
} }
Xfree(seg); gen->segment_conv = NULL; Xfree(seg); gen->segment_conv = NULL;
} }
...@@ -1156,14 +1149,13 @@ destroy_gen( ...@@ -1156,14 +1149,13 @@ destroy_gen(
XLCdGenericPart *gen = XLC_GENERIC_PART(lcd); XLCdGenericPart *gen = XLC_GENERIC_PART(lcd);
destroy_SegConv(gen); destroy_SegConv(gen);
destroy_CodeSetList(gen); destroy_CodeSetList(gen);
if (gen->mb_parse_table) {
Xfree(gen->mb_parse_table); Xfree(gen->mb_parse_table);
gen->mb_parse_table = NULL; gen->mb_parse_table = NULL;
}
if (gen->mb_parse_list) { Xfree(gen->mb_parse_list);
Xfree(gen->mb_parse_list); gen->mb_parse_list = NULL;
gen->mb_parse_list = NULL;
}
} }
/* VW/UDC end 95.01.08 */ /* VW/UDC end 95.01.08 */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment