Keyboard.c: simplify code

Based on PVS Studio finding: "V547 Expression 'data' is always true."

Keyboard.c: simplify code
41bf8397 · Ulrich Sibiller · 5735e164 · 41bf8397
Commit 41bf8397 authored Aug 03, 2020 by Ulrich Sibiller
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

Keyboard.c nx-X11/programs/Xserver/hw/nxagent/Keyboard.c +3 -5

No files found.
--- a/nx-X11/programs/Xserver/hw/nxagent/Keyboard.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Keyboard.c
@@ -1425,11 +1425,9 @@ static void nxagentXkbGetRemoteNames(void)
  if ((after > 0) || (type != XA_STRING) || (format != 8))
  {
-    if (data)
+    /* data non-null - has been checked above */
-    {
+    SAFE_XFree(data);
-      SAFE_XFree(data);
+    return;
-      return;
-    }
  }
  char *name = data;